- Issue created by @arti_parmar
- Status changed to Active
over 1 year ago 11:00am 22 June 2023 - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 11:01am 22 June 2023 - Status changed to Needs work
over 1 year ago 7:19pm 22 June 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
- $tokens = $this->coreToken->getInfo(); + $this->coreToken->getInfo();
Token::getInfo()
just returns information for a token. If that information is not necessary, it is not necessary to even call that method.- foreach ($entity->get($current_key) as $key => $value) { - foreach ($value->getValue() as $key_value => $value_value) { + foreach ($entity->get($current_key) as $value) { + foreach ($value->getValue() as $value_value) {
- - $display_field_config = $field['settings']; - + // Check the currently selected plugin, and merge persisted values for its
Since this issue is focusing on removing unused variables, and those changes do not involve lines where unused variables are set, those changes are off-topic.
Also, for empty lines, it is not necessary to add heading spaces. - Status changed to Closed: duplicate
over 1 year ago 8:00pm 22 June 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
Thank you for the patch!
Since those are warnings/errors reported by PHP_CodeSniffer, it is preferable to create a single issue to resolve the warnings/errors reported by PHP_CodeSniffer. There is already 📌 Fix the issues reported by PHP_CodeSniffer Postponed , whose scope should be changed to be a broader issue, as described in that issue.