- Issue created by @Zarpele
The
ConsumersForm
should have the following:/** * The available serializer formats. * * @var string[] */ protected array $formats; /** * {@inheritdoc} */ public static function create(ContainerInterface $container) { $instance = parent::create($container); $formats = $container->getParameter('serializer.formats'); $instance->formats = array_combine($formats, $formats); return $instance; }
and the constructor can be removed. I've used the pattern before. It avoids changing the signature of the constructor of the parent
ConfigFormBase
.solideogloria → changed the visibility of the branch 3367992-improvements to hidden.
- Status changed to Needs review
about 1 year ago 9:05pm 5 December 2023 Made the recommended changes plus some.
You should also make 2.0.x the default branch on GitLab. It's very confusing to have the default branch be 8.x-1.x, which isn't used anymore.
This updated patch is for convenience after the most recent MR commit.
It includes the changes from 🐛 Prevents normal website access by restricting all routes by default Needs work . There were conflicts between the two sets of changes. So now this contains them all.
- Status changed to Needs work
about 1 year ago 7:56pm 8 December 2023