Use constructor promotions

Patch using constructor promotion to simplify code.

+++ b/src/DashboardListBuilder.php
@@ -4,53 +4,14 @@ namespace Drupal\dashboard;
-  /**
-   * {@inheritdoc}
-   */
-  public static function createInstance(ContainerInterface $container, EntityTypeInterface $entity_type) {
-    return new static(
-      $entity_type,
-      $container->get('entity_type.manager')->getStorage($entity_type->id()),
-      $container->get('messenger')
-    );
-  }

I would merge this without even testing if it weren't for this removal. Not sure if we still need that.

Parent class implements Messenger trait, so that service is redundant. It can be injected, though.

Oh I missed you also added the github PR: https://github.com/penyaskito/dashboard-initiative/pull/20.
If tests pass we are good, and they passed.

penyaskito → credited andypost → .

I'm crediting @andypost here too

Committed, thanks!

Nice! reviewed and even inheritance valid

+++ b/src/DashboardAccessControlHandler.php
@@ -19,11 +19,19 @@ use Symfony\Component\DependencyInjection\ContainerInterface;
+  public function __construct(
+    EntityTypeInterface $entity_type,
+    protected EntityTypeManagerInterface $entityTypeManager

++

Automatically closed - issue fixed for 2 weeks with no activity.