- Issue created by @gurvan
- last update
about 1 year ago 4 pass - @gurvan opened merge request.
- Status changed to Needs work
12 months ago 1:58pm 30 June 2023 - 🇭🇺Hungary nagy.balint
Hi!
I think that potentially the DateTimeFlatPickrWidgetTrait could be used here to avoid code duplication.
If needed the trait can be changed slightly to make that possible, like if the public static function defaultSettings() { needs to be separated into two methods (or that the trait only provides the default settings array, and the + parent::defaultSettings(); could be in the specific classes).
- First commit to issue fork.
- last update
12 months ago 4 pass - Status changed to Needs review
12 months ago 10:06am 3 July 2023 - last update
12 months ago 4 pass - Status changed to Needs work
12 months ago 5:06pm 3 July 2023 - 🇭🇺Hungary nagy.balint
The DateTimeFlatPickrWidgetTrait already existed, so this MR is quite incorrect.
- 🇫🇷France gurvan
Hi, sorry but I created this patch for an urgent need on a project, I will provide a new patch with a better approach in order to avoid duplicate code.
Hope I could provide the new patch this week.
Regards
- Assigned to gurvan
-
nagy.balint →
committed d58270ef on 3.0.x
Issue #3367844 by gurvan, D-XPERT, nagy.balint: Create Form element to...
-
nagy.balint →
committed d58270ef on 3.0.x
- Status changed to Fixed
27 days ago 10:15pm 1 June 2024 Automatically closed - issue fixed for 2 weeks with no activity.