Background image field should be optional

Created on 19 June 2023, over 1 year ago
Updated 21 June 2023, over 1 year ago

Problem/Motivation

Designs allow for an optional image in the Donate block but it's currently required

Steps to reproduce

- add a Donate block
- attempt to save without adding an image
- observe Background image is required

Proposed resolution

- Make Background Image optional
- Add update hook to update existing installs

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States froboy Chicago, IL

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @froboy
  • @froboy opened merge request.
  • Status changed to Needs review over 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States froboy Chicago, IL

    @podarok this is ready for review. I've bundled a number of changes together.

    To test:

    - update module and run `drush updb`
    - add a Donate block and observe that Amount Label and Form Element ID fields are required
    - observe Background Image is not required
    - save the block
    - observe colors change with colorways and border radius

  • Issue was unassigned.
  • Status changed to Fixed over 1 year ago
  • πŸ‡ΊπŸ‡¦Ukraine podarok Ukraine

    tnx, tagged

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024