- Issue created by @daniel.bosen
- last update
over 1 year ago 32 pass - @danielbosen opened merge request.
- last update
over 1 year ago Composer require-dev failure - π©πͺGermany daniel.bosen
I accidentally created the issue in the wrong issue queue, that's why we have the strange fork of config_update...
- π©πͺGermany chr.fritsch π©πͺπͺπΊπ
chr.fritsch β made their first commit to this issueβs fork.
- last update
over 1 year ago 32 pass - last update
over 1 year ago 23 pass, 3 fail - π¬π§United Kingdom alexpott πͺπΊπ
In order to fix the test failures on 10.1.x we need to fix a regression introduced in core - see π DiffOpOutputBuilder does not correctly match the 10.0.x implementation and produces unexpected output Fixed .
- π―π΄Jordan Rajab Natshah Jordan
Thank you, for following up on supporting Drush
~12.0
Suggesting to have
"require": { "drupal/core": "^9 || ^10.1.0", "drupal/config_update": "^1.5 || ^2.0", "symfony/console": "^4.4.15 || ^5.1 || ^6.1", "chi-teck/drupal-code-generator": "~2.4.0 || ~3.0" }, "require-dev": { "drupal/checklistapi": "~1.0 || ~2.0", "drush/drush": "~11.0 || ~12.0" },
Happy with anyway to Drush
~12.0
tho. - π¬π§United Kingdom alexpott πͺπΊπ
@Rajab Natshah why only 10.1.0? As far as I know we might be broken on 10.1.0 as π DiffOpOutputBuilder does not correctly match the 10.0.x implementation and produces unexpected output Fixed will not be fixed there. But 10.0.* used the old differ so we should be good there.
- last update
over 1 year ago 26 pass, 2 fail - last update
over 1 year ago PHPLint Failed - last update
over 1 year ago Composer require failure - π¬π§United Kingdom alexpott πͺπΊπ
Generator command registration changed between 11 and 12 so we're not going to be able to provide an update helper that is compatible with Drush 11 and 12 without a silly amount of work. I think we should make 3.x only compatible with Drupal <10.1 and Drush 11 and Code generator 2. And then have a new 4.x branch that is Drush 12, Drupal >10.1.(new to work this out), and Code generator 3.
Additional changes to how Drush registers its services in Drush 12 mean that the event subscribers in drush.servives.yml are no longer registered on the Drupal container which means they don't work. The easy fix here is to make these event listeners proper Drupal event listeners. I think this is okay because they'll never be triggered during the regular runtime. But, on the other hand, they really are not runtime events so this is really annoying.
- last update
over 1 year ago PHPLint Failed - π―π΄Jordan Rajab Natshah Jordan
Noted;
You are right Alex, I agree with you.Sorry, I'm maybe moving forward and fast with
~10.1.0
No any prob. with~10.0
too.The 4.x branch for sure will do good for all.
- last update
over 1 year ago Composer require failure - Status changed to Needs review
over 1 year ago 9:40am 19 September 2023 -
alexpott β
committed b43d7a16 on 4.0.x authored by
daniel.bosen β
Issue #3367692: Update helper is not drush 12 compatible
-
alexpott β
committed b43d7a16 on 4.0.x authored by
daniel.bosen β
- π¬π§United Kingdom alexpott πͺπΊπ
Merged this in to 4.0.x will open a follow-up issue about the events - just to ensure this makes it into the release notes for 4.0
- Status changed to Fixed
over 1 year ago 3:16pm 19 September 2023 Automatically closed - issue fixed for 2 weeks with no activity.