- Issue created by @dww
- @dww opened merge request.
- Status changed to Needs work
over 1 year ago 2:57am 19 June 2023 - πΊπΈUnited States dww
Alas, https://git.drupalcode.org/project/entitygroupfield/-/pipelines/12586 failed. Opened some MR threads for parts that seem broken.
- last update
over 1 year ago 4 pass - last update
over 1 year ago 4 pass - Status changed to Needs review
over 1 year ago 11:26pm 19 June 2023 - πΊπΈUnited States moshe weitzman Boston, MA
dww β credited moshe weitzman β .
- πΊπΈUnited States dww
Got some solid help in Slack from @cmlara and @moshe, thanks!
My confusion is that when you have a job inheriting from something else, you have to go out of your way to merge steps using
!reference[job-id, thing]
.https://git.drupalcode.org/project/entitygroupfield/-/pipelines/12666 is now working as expected, and the same commit ran to completion with the right versions of everything when I ran it locally. Now we just have to see that it works on d.o, too. π
- πΊπΈUnited States dww
Excellent, only once the canary config passed build, validate and test did any of the matrix build jobs launch:
- πΊπΈUnited States dww
Huzzah, https://git.drupalcode.org/project/entitygroupfield/-/pipelines/12666 passed on all 4 configurations. π
Merged to 2.0.x and pushed.
There are probably cleaner ways to implement this, but it's a start. π Let's call this fixed, and open follow-ups for future improvements.
Thanks again!
-Derek - Status changed to Fixed
over 1 year ago 11:41pm 19 June 2023 Automatically closed - issue fixed for 2 weeks with no activity.