- Issue created by @Qusai Taha
- Status changed to Needs review
over 1 year ago 2:51pm 18 June 2023 - Open on Drupal.org →Core: 9.5.5 + Environment: PHP 8.1 & MySQL 8last update
over 1 year ago Waiting for branch to pass - 🇯🇴Jordan Rajab Natshah Jordan
Thanks, Qusai, for reporting and patching
Will this change keep Vartheme Claro
~3.0
work with bothDrupal~9.0
and Drupal~10.0
using the same base code?Vartheme Claro
We could manage Vartheme Claro~4.0
intended for Drupal 10 but it's using the Gin Admin theme.~3.0
with Drupal~10.1.0
Only as an upgrade option for old Varbase~9.0
sitesSuggesting to change the fix to work for both D9 and D10, and with CKEditor4 and CKEditor5
Have a hook and check for the version of Drupal then add extend theclaro/ckeditor-dialog
library existed.Please, change the status of this issue to Needs work if you are intended to do farther work on it.
- Status changed to Needs work
over 1 year ago 6:32am 20 June 2023 - 🇯🇴Jordan Qusai Taha Amman
Thanks, Rajab, I agree with the solution to apply the fix to work for both D9 and D10, and with CKEditor4 and CKEditor5
Have a hook and check for the version of Drupal then add extend the claro/ckeditor-dialog library if it existed. - Assigned to Rajab Natshah
- Status changed to Active
over 1 year ago 7:27pm 22 June 2023 - 🇯🇴Jordan Rajab Natshah Jordan
Facing other errors with
ckeditor-editor
andckeditor-admin
tooDrupal\Core\Asset\Exception\InvalidLibrariesExtendSpecificationException: The specified library "claro/ckeditor-editor" does not exist. in Drupal\Core\Asset\LibraryDiscoveryCollector->applyLibrariesExtend() (line 154 of core/lib/Drupal/Core/Asset/LibraryDiscoveryCollector.php).
and
Drupal\Core\Asset\Exception\InvalidLibrariesExtendSpecificationException: The specified library "claro/ckeditor-admin" does not exist. in Drupal\Core\Asset\LibraryDiscoveryCollector->applyLibrariesExtend() (line 154 of core/lib/Drupal/Core/Asset/LibraryDiscoveryCollector.php).
- Open on Drupal.org →Core: 9.5.5 + Environment: PHP 8.1 & MySQL 8last update
over 1 year ago Waiting for branch to pass - @rajab-natshah opened merge request.
-
Rajab Natshah →
committed b179ca84 on 3.0.x
Issue #3367501: Fix Error When Using Vartheme Claro 3.0.x on Drupal 10
-
Rajab Natshah →
committed b179ca84 on 3.0.x
- 🇯🇴Jordan Rajab Natshah Jordan
Switch the following libraries extend to logic of code. only to work with Drupal 9 and with the CKEditor 4 ( ckeditor → ) module is enabled
Mapping old core libraries and new libraries by the CKEditor 4 contrib modulelibraries-extend: ckeditor/drupal.ckeditor: - claro/ckeditor-editor ckeditor/drupal.ckeditor.admin: - claro/ckeditor-admin core/ckeditor: - claro/ckeditor-dialog
https://git.drupalcode.org/project/ckeditor/-/blob/1.0.x/ckeditor.librar...ckeditor/drupal.ckeditor
=>ckeditor/drupal.ckeditor
ckeditor/drupal.ckeditor.admin
=>ckeditor/drupal.ckeditor.admin
core/ckeditor
=>ckeditor/ckeditor
-
Rajab Natshah →
committed a9fea7fa on 3.0.x
Issue #3367501: Fix Error When Using Vartheme Claro 3.0.x on Drupal 10
-
Rajab Natshah →
committed a9fea7fa on 3.0.x
- Issue was unassigned.
- Status changed to Fixed
over 1 year ago 11:46am 24 June 2023 -
Rajab Natshah →
committed 8d975a31 on 3.0.x
Issue #3367501: Fix Error When Using Vartheme Claro 3.0.x on Drupal 10
-
Rajab Natshah →
committed 8d975a31 on 3.0.x
- 🇯🇴Jordan Rajab Natshah Jordan
✅ Released vartheme_claro-3.0.11 →
Automatically closed - issue fixed for 2 weeks with no activity.