Compatibility with version 2.x of dependencies and SDC in Core

Not sure if this issue should be moved to the Component Libraries: Blocks project.

I am surprised this is the only issue you encountered so far. CL Block is still not compatible with the 2.x series and with SDC in core.

Can we turn this issue into a more generic issue for SDC compatibility?

Thanks for passing by this issue.

Yes, for sure if you like that.
I had one issue before this one
🐛 Fix Block Settings TypeError: array_filter() when pressing Save configuration Needs review

Today I faced the following issue too.
🐛 Fix TypeError when editing Text formats and editors for the Cl Component Embed filter having Argument #1 ($input) must be of type array, null given Active

It feels that a one refactor issue could manage refactoring the code to support SDC from Drupal ~10.1.0 and CL family of modules to be inline with the 2.0.x branches.

More testing rounds and experimentation with all dynamic config and behaviors.

I agree with @e0ipso, I was trying to make it work with the latest version of Drupal core and all other modules and I have found more things to fix, so instead of having a lot of small issues that don't work independently I would rename this for all the compatibility issues.

Once the patch get ready maybe we can create a 2.x version.

I started a new issue fork and MR with multiple fixes:

• Changed references to CL components to SDC
• Removed variants functionality
• Removed CL Components dependency
• Multiple fixes to get the component schema

There are some things I didn't test yet, like the CK editor embed, I will move it to needs review for now.

@jidrone it really shows that you have been getting familiar with the codebase! This MR is absolutely fantastic!

I left a bunch of comments in the MR.

Some overarching questions & requests:

1. Drupal 10 will use CKEditor5, but I didn't see any changes in this department. Perhaps we can add a dependency to https://www.drupal.org/project/ckeditor → instead?
2. We now have sdc_tags as part of cl_editorial to deal with the configuration form on what components are eligible for each feature. Can we also migrate to that as well, or create a ticket to do so? There is an example on how to do it in sdc_display
3. Can you post screenshots of the module working after the patch? This will help identify the features you have tested.

@jidrone I think this is great for Layout Builder workflows and sites sticking behind with CKEditor4, but in the future I'd like to break this module in two: sdc_block and sdc_ckeditor. What do you think about this?

Yes, I think the CKEditor integration should be in a separate module.

Dave Reid → made their first commit to this issue’s fork.