[meta] Improve support for entity types without a canonical link

Starting looking into this at DrupalCamping Wolfsburg 2023.

What I did was to "fix" all the entity type annotations to remove the canonical link where it's not appropriate IMO and then taking a look at what breaks (see https://www.drupal.org/project/drupal/issues/2274167#comment-15108518 📌 [ignore] Patch testing issue Active ).

I then started "fixing" all the tests, although a bunch of the fixes are fairly crude and not meant to actually go in as is. But my plan would be to first get a green patch here and then see what can be pulled out how as actually valid fixes. Then actually changing the annotations could either be done here or in dedicated issues, as well.

Anyway, this is how far I got so far.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Want to at least see the test results.

The last submitted patch, 4: 3367475-4.patch, failed testing. View results →

Next try, let's see...

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Please review. Fixed error from #7.

The last submitted patch, 8: 3367475-8.patch, failed testing. View results →

Thanks @sathki_dev!

Brought back the content_translation.link_relation_types.yml file that was missing from your patch, I presume unintentionally.

Also fixes the remaining tests, hopefully without breaking anything else. Let's see.

The last submitted patch, 10: 3367475-10.patch, failed testing. View results →

Resolved the error by removing the test case. It doesn't make sense to have the test case for checking canonical link as it is removed here.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Thanks @sakthi_dev for the final fix.

From my point of view the proof-of-concept part of this issue is now complete (even though) we technically do not have a completely green patch here. I think it now makes sense to split out some of the actual issues and once those have been resolved, we can do another round and see if we can actually start removing the canonical link of some or all of the entity types.

I've already opened one issue, although that's not really a requirement (so this is not strictly postponed on that), it just came up above when I added the drupal:content-translation-overview links to entities temporarily for testing purposes: 🐛 Installing Content Translation module breaks Rest resources Needs work

Next, I plan to open two separate issues which will fix the majority of the problems as far as I can tell:

• Make the $rel = 'canonical' default of of Entity::toUrl() dynamic and fall back to edit-form if that exists (and canonical does not)
• Make Content Translation work for entities without a canonical link. The canonical link is only used to get the "base path" to attach the translation UI to, so we should just fall back to the edit link if that exists.

Opened 📌 Fall back to 'edit-form' as default $rel in EntityBase::toUrl() Fixed now.