- Issue created by @codechefmarc
- Assigned to codechefmarc
- Assigned to samit.310@gmail.com
- Status changed to Needs work
about 1 year ago 10:19am 26 September 2023 - Issue was unassigned.
- Status changed to Needs review
about 1 year ago 10:20am 26 September 2023 - 🇺🇸United States codechefmarc
Thanks, @samit.310@gmail.com - Good patch, however, since I'd like to make these configurable anyways, I added some new code to the dev branch for a config form, save the strings as config, and added code for the translations so they work with core config translations. If you want to take a look, I'd love a second pair of eyes. I'm adding a few things to the dev branch like other fixes from other issues on here as well.
- 🇮🇳India samit.310@gmail.com
Hi @codechefmarc,
I reviewed following PR, Looks good to me.
https://git.drupalcode.org/project/reading_rating/-/commit/23fbf08a7677e...
Thanks
Samit K - Status changed to Fixed
3 months ago 11:28pm 9 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.