Contrib.social

Change how we log payment responses to the order

Open on Drupal.org →
Created on 14 June 2023, over 1 year ago
Updated 27 June 2023, over 1 year ago

There are various parts of the code that store items in the related order's data array. I'm not sure it's necessary anywhere it's used. However, at the very lease, since we have a response status on the payment entity, when we validate a payment, we don't need to store its status or successful response code in the order.

Additionally, instead of putting a failing response code (either the 902 or 2001 defined here), we should define a log template and log the failing message to the order itself:

Moneris Checkout payment failed: 3-D Secure failed on response (902)

Or

Moneris Checkout payment failed: Invalid ticket/ticket re-use (2001)

This should be doable via a single log template that has placeholders for the message and the code as pulled from the docs page.

Review the other places where we put information into the order data array, too. If those items are just being stored for reference, they aren't really useful throughout the user interface. If there are other items we should consider converting to logs instead, open follow-up tickets for each one.

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇸United States rszrama

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024