- Issue created by @yashmalviya
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 12:15pm 14 June 2023 - last update
almost 2 years ago Patch Failed to Apply - last update
almost 2 years ago 147 pass, 14 fail - 🇮🇳India Kaustab_Roy
tested the patch#2 , applied cleanly.
It resolved the dependency injection issue as per summary.Found some translation errors added them in the above patch along with all the changes in patch#2.
The last submitted patch, 3: 3366728-3.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- Status changed to Closed: won't fix
almost 2 years ago 7:36pm 14 June 2023 - 🇺🇸United States cmlara
As discussed in other issues we are not accepting PHPCS fixes at this time for either the 3.x (primarily only api breaching changes remain) and 4.x (being fixed as part of other initiatives) especially since some of the files being fixed will not actually exist in 4.x and they remain only to indicate what features have not yet been ported.