Deprecated json_decode in H5PContent

Deprecated function: json_decode(): Passing null to parameter #1 ($json) of type string is deprecated in Drupal\h5p\Entity\H5PContent->getMetadata() (line 249 of modules/contrib/h5p/src/Entity/H5PContent.php). Drupal\h5p\Entity\H5PContent->getMetadata() (Line: 228) Drupal\h5p\Entity\H5PContent->getFilteredParameters() (Line: 307) Drupal\h5p\Entity\H5PContent->getH5PIntegrationSettings(1) (Line: 58) Drupal\h5p\Plugin\Field\FieldFormatter\H5PDefaultFormatter->viewElements(Object, 'en') (Line: 89) Drupal\Core\Field\FormatterBase->view(Object, 'en') (Line: 265) Drupal\Core\Entity\Entity\EntityViewDisplay->buildMultiple(Array) (Line: 266) Drupal\layout_builder\Entity\LayoutBuilderEntityViewDisplay->buildMultiple(Array) (Line: 340) Drupal\Core\Entity\EntityViewBuilder->buildComponents(Array, Array, Array, 'full') (Line: 24) Drupal\node\NodeViewBuilder->buildComponents(Array, Array, Array, 'full') (Line: 282) Drupal\Core\Entity\EntityViewBuilder->buildMultiple(Array) (Line: 239) Drupal\Core\Entity\EntityViewBuilder->build(Array) call_user_func_array(Array, Array) (Line: 101) Drupal\Core\Render\Renderer->doTrustedCallback(Array, Array, 'Render #pre_render callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. The callback was %s. See https://www.drupal.org/node/2966725', 'exception', 'Drupal\Core\Render\Element\RenderCallbackInterface') (Line: 788) Drupal\Core\Render\Renderer->doCallback('#pre_render', Array, Array) (Line: 374) Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 204) Drupal\Core\Render\Renderer->render(Array, ) (Line: 242) Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}() (Line: 580) Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 243) Drupal\Core\Render\MainContent\HtmlRenderer->prepare(Array, Object, Object) (Line: 132) Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse(Array, Object, Object) (Line: 90) Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray(Object, 'kernel.view', Object) call_user_func(Array, Object, 'kernel.view', Object) (Line: 142) Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch(Object, 'kernel.view') (Line: 174) Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 81) Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58) Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48) Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106) Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85) Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 50) Drupal\ban\BanMiddleware->handle(Object, 1, 1) (Line: 48) Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51) Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23) Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 718) Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Comments & Activities

Issue created by @ryanrobinson_wlu
Comment over 1 year ago →
🇨🇦Canada ryanrobinson_wlu

Comment over 1 year ago →

🇨🇦Canada ryanrobinson_wlu

Inspired by the fix in 3344519, I got mine working by changing the NULL values to empty quotes instead. Starting at line 247 of H5PContent:

    $metadata = [
      'title' => $this->get('title')->value,
      'authors' => json_decode(($this->get('authors')->value) ?? ''),
      'source' => $this->get('source')->value,
      'yearFrom' => $this->get('year_from')->value,
      'yearTo' => $this->get('year_to')->value,
      'license' => $this->get('license')->value,
      'licenseVersion' => $this->get('license_version')->value,
      'licenseExtras' => $this->get('license_extras')->value,
      'authorComments' => $this->get('author_comments')->value,
      'defaultLanguage' => $this->get('default_language')->value,
      'changes' => json_decode(($this->get('changes')->value) ?? ''),
    ];

Trying to figure out how to put this into a functioning patch.

Comment over 1 year ago →
🇨🇦Canada ryanrobinson_wlu
Patch that I believe works.
Status changed to Needs review over 1 year ago7:35pm 12 June 2023
Comment over 1 year ago →
🇨🇦Canada ryanrobinson_wlu
Comment about 1 year ago →
🇩🇪Germany ammaletu Bonn, Germany
I think this is a duplicate of https://www.drupal.org/project/h5p/issues/3281812 🐛 json_decode(): Passing null to parameter #1 ($json) of type string is deprecated Needs review .
Comment about 1 year ago →
🇨🇦Canada ryanrobinson_wlu
It's the same function deprecation at least. My patch was on different functions than that one's patch, so I can't easily tell if they're both fixing the same problem from a different direction or whether both pieces needed fixed.
Status changed to Closed: duplicate about 1 year ago5:30pm 30 October 2023
Comment about 1 year ago →
🇨🇦Canada shaundychko
The fix here is included already in 🐛 json_decode(): Passing null to parameter #1 ($json) of type string is deprecated Needs review
Compare the commit to 2.0.x https://git.drupalcode.org/project/h5p/-/commit/43daa83a9d3a2988730965c4... with the patch in this issue.