- Issue created by @darren oh
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.1 & MySQL 8last update
almost 2 years ago Waiting for branch to pass - @darren-oh opened merge request.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.1 & MySQL 8last update
almost 2 years ago Waiting for branch to pass - Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 2:25am 12 June 2023 - Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.1 & MySQL 8last update
almost 2 years ago Waiting for branch to pass - Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.1 & MySQL 8last update
almost 2 years ago Waiting for branch to pass - Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.1 & MySQL 8last update
almost 2 years ago Waiting for branch to pass - Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
31:32 49:55 Queued - 🇺🇸United States jrockowitz Brooklyn, NY
For reference, what version of Drupal are you using? 9.5.x or 10.x?
- 🇺🇸United States darren oh Lakeland, Florida
I tried 9.5.x, 10.0.x, and 10.1.x. I tested the updated patches and instructions on 10.1.x. Need to test whether they work on 10.0.x and 9.5.x.
- last update
almost 2 years ago Composer require failure - last update
almost 2 years ago Composer require failure - 🇺🇸United States jrockowitz Brooklyn, NY
The entity embed module is not available to 10.x but we should support 9.x and 10.x. Thanks for your help.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.1 & MySQL 8last update
almost 2 years ago Waiting for branch to pass - Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.1 & MySQL 8last update
almost 2 years ago Waiting for branch to pass - Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.1 & MySQL 8last update
almost 2 years ago Waiting for branch to pass - Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.1 & MySQL 8last update
almost 2 years ago Waiting for branch to pass - Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.1 & MySQL 8last update
almost 2 years ago Waiting for branch to pass - Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.1 & MySQL 8last update
almost 2 years ago Waiting for branch to pass - Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.1 & MySQL 8last update
almost 2 years ago Waiting for branch to pass - 🇺🇸United States darren oh Lakeland, Florida
Only works with 10.1.x because the patch for 🐛 "Add another item" field button is displayed as a modal action Fixed can only work with one version.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.1 & MySQL 8last update
almost 2 years ago Waiting for branch to pass - @darren-oh opened merge request.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.1 & MySQL 8last update
almost 2 years ago Waiting for branch to pass - 🇺🇸United States jrockowitz Brooklyn, NY
@DarrenOh What should we do about support 9.5.x and 10.x?
We could add version numbers to the composer.libraries.json.
I am included to support only 9.5.x until this ticket is resolved
📌 Support Drupal 10 Fixed - 🇺🇸United States jrockowitz Brooklyn, NY
Hey, entity embed is now D10 compatible.
https://www.drupal.org/project/entity_embed/releases/8.x-1.4 →
I think we should move the demo and all the schemadotorg code to be only for D10.
What do you think?
- 🇺🇸United States darren oh Lakeland, Florida
D10 only sounds good for now. I like the idea of version numbers on composer.libraries.json. I'm still working on the 3366108-not-installable-10.0.x branch. Once I have that working smoothly, I can try a D9 version.
- 🇺🇸United States jrockowitz Brooklyn, NY
@Darren Oh Let me see if I can use the PR AS-IS and get everything working via D10.
- 🇺🇸United States jrockowitz Brooklyn, NY
Only works with 10.1.x because the patch for #3151534: "Add another item" field button is displayed as a modal action can only work with one version.
How about we move this patch for 9.5.x and 10.1.x to a composer.patches.VERSION.json file?
This will reduce code duplication.
BTW, I am not following which branch should be merged and we should reference to *.patch files and *.diff which can change.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.1 & MySQL 8last update
almost 2 years ago Waiting for branch to pass - Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.1 & MySQL 8last update
almost 2 years ago Waiting for branch to pass - @darren-oh opened merge request.
- 🇺🇸United States darren oh Lakeland, Florida
Depends on the Drupal version you choose to support. I'm updating to just one merge request with versioned composer.libraries.json files. Curious about your idea for reducing code duplication. Can we discuss on Slack?
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.1 & MySQL 8last update
almost 2 years ago Waiting for branch to pass - 🇺🇸United States darren oh Lakeland, Florida
Consolidated into one merge request.
- 🇺🇸United States jrockowitz Brooklyn, NY
Thank you for merging the requests. I am going to test the changes and make some minor tweaks.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.1 & MySQL 8last update
almost 2 years ago Waiting for branch to pass - 🇺🇸United States jrockowitz Brooklyn, NY
I would like to merge the patch and then make more minor tweaks as needed.
-
jrockowitz →
committed 6b906bf2 on 1.0.x authored by
Darren Oh →
Issue #3366108 by Darren Oh, jrockowitz: Fix installation not working
-
jrockowitz →
committed 6b906bf2 on 1.0.x authored by
Darren Oh →
- Status changed to Fixed
almost 2 years ago 10:48am 15 June 2023 Automatically closed - issue fixed for 2 weeks with no activity.