Fix installation not working

For reference, what version of Drupal are you using? 9.5.x or 10.x?

I tried 9.5.x, 10.0.x, and 10.1.x. I tested the updated patches and instructions on 10.1.x. Need to test whether they work on 10.0.x and 9.5.x.

The entity embed module is not available to 10.x but we should support 9.x and 10.x. Thanks for your help.

Only works with 10.1.x because the patch for 🐛 "Add another item" field button is displayed as a modal action Fixed can only work with one version.

@DarrenOh What should we do about support 9.5.x and 10.x?

We could add version numbers to the composer.libraries.json.

I am included to support only 9.5.x until this ticket is resolved
📌 Support Drupal 10 Fixed

Hey, entity embed is now D10 compatible.

https://www.drupal.org/project/entity_embed/releases/8.x-1.4 →

I think we should move the demo and all the schemadotorg code to be only for D10.

What do you think?

D10 only sounds good for now. I like the idea of version numbers on composer.libraries.json. I'm still working on the 3366108-not-installable-10.0.x branch. Once I have that working smoothly, I can try a D9 version.

@Darren Oh Let me see if I can use the PR AS-IS and get everything working via D10.

Only works with 10.1.x because the patch for #3151534: "Add another item" field button is displayed as a modal action can only work with one version.

How about we move this patch for 9.5.x and 10.1.x to a composer.patches.VERSION.json file?

This will reduce code duplication.

BTW, I am not following which branch should be merged and we should reference to *.patch files and *.diff which can change.

Which MR should be merged?

Depends on the Drupal version you choose to support. I'm updating to just one merge request with versioned composer.libraries.json files. Curious about your idea for reducing code duplication. Can we discuss on Slack?

Darren Oh → closed merge request !6

Darren Oh → closed merge request !5

Consolidated into one merge request.

Thank you for merging the requests. I am going to test the changes and make some minor tweaks.

I would like to merge the patch and then make more minor tweaks as needed.

Automatically closed - issue fixed for 2 weeks with no activity.