- Issue created by @danielspeicher
- 🇩🇪Germany jurgenhaas Gottmadingen
Looked into that and have some sugestions:
- We should add a method to the HelpdeskInterface to load all user ids (not user entities) with access to the helpdesk.
- That method could probably find all roles that have the permission
access helpdesk
, and then find all user ids from users, that have at least one of those roles and are active. - All loops, that currently work with the
$users
array will have to load the user entity one by one as they will then only received the user id, not the user. This is the case in\Drupal\helpdesk_integration\PluginBase::updateAllUsers
and inhelpdesk_integration_batch_push_users
- Assigned to jurgenhaas
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 9:50am 19 June 2023 - @jurgenhaas opened merge request.
- Status changed to RTBC
over 1 year ago 12:08pm 20 June 2023 - 🇩🇪Germany danielspeicher Steisslingen
That's pretty cool. I like that you moved the loading method to the service.
-
jurgenhaas →
committed bd420dc7 on 1.1.x
Issue #3365341 by jurgenhaas, danielspeicher: Do not load all users in...
-
jurgenhaas →
committed bd420dc7 on 1.1.x
- Status changed to Fixed
over 1 year ago 12:48pm 20 June 2023 Automatically closed - issue fixed for 2 weeks with no activity.