Update Composer Stager to 2.0.0-alpha2 to resolve a bug in the rsync file syncer

Oh, this will also need an upstream follow-up to ensure that Composer Stager's PHP file syncer also treats its exclusions the same way rsync does. Consistency is crucial here.

i just reverted my change, seems like i'm missing something, wouldn't leaving the slashes in the prefix make relative paths appear to be absolute?

the excluded paths lists looks like, most of them now have paths staring from ./ but i don't think they are being actually excluded because of the failing tests.

Maybe I shouldn't have added the ./ to the file names and only to the directories.

is this going in the right direction ? or am i missing something?

The issue summary only talks about the rsync file syncer, not the php one.

How does this affect that? AFAICT it shouldn't affect that at all, because we're not collecting a list of patterns to exclude, but a list of paths to exclude. This becomes clearer by reading \Drupal\package_manager\PathExcluder\GitExcluder::excludeGitDirectories(), which if we were excluding patterns wouldn't have to first find all paths to exclude: it could then just exclude .git and be done.

Isn't this just a bug in Composer Stager? It's either a bug in:

1. \PhpTuf\ComposerStager\Infrastructure\Service\FileSyncer\RsyncFileSyncer? AFAICT that's just misinterpreting the PathListInterface $exclusions it receives.
2. or in \PhpTuf\ComposerStager\Infrastructure\Value\PathList\PathList::assertValidInput()

Agree with #12 we need an issue in Composer-Stager. Depending on how quickly a fix can be implemented there we should wait for that or not

Opened https://github.com/php-tuf/composer-stager/issues/183 against Composer Stager.

Assuming this gets fixed upstream (and I think it is likely that it will be), we should probably just close out this issue once we have updated to a new release that contains the bugfix. But for now, postponing on that.

Looks good

2.0.0-alpha2

Automatically closed - issue fixed for 2 weeks with no activity.