- Issue created by @Akshay kashyap
- @akshay-kashyap opened merge request.
- Status changed to Needs review
over 1 year ago 10:08am 6 June 2023 - Issue was unassigned.
- Status changed to Needs work
over 1 year ago 10:35am 10 August 2023 - ๐ฎ๐ณIndia rushiraval
I have reviewed your changes in README.md You have just copied Readme.txt file to README.md but need to rearrange sections as per
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... โ
- ๐ฎ๐ณIndia Anjali Mehta
Anjali Mehta โ made their first commit to this issueโs fork.
- Status changed to Needs review
over 1 year ago 6:49am 14 August 2023 - Status changed to Needs work
over 1 year ago 4:53pm 23 August 2023 - ๐ฎ๐ณIndia abhaysaraf
Thank you Anjali for updating the content of this file with the correct format as per https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... โ .
I would like to merge it but there is no PR, can you raise one? If possible, please accommodate suggestions added within the commit (at https://git.drupalcode.org/issue/colorpalette-3365045/-/commit/bd4e4493d...). Thank you.
- ๐ฎ๐ณIndia rushiraval
Still needs needs some work. it is not as per recommendation by Drupal.
Requirement & configuration section missing.Please Refer : https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... โ
- Assigned to Anjali Mehta
- ๐ฎ๐ณIndia Anjali Mehta
Thank you for the review. I will work on the suggestions.
- @anjali-mehta opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 6:32am 25 August 2023 - ๐ฎ๐ณIndia Anjali Mehta
Hello @abhaysaraf
Created MR5 to update the README.md file as per the Drupal READMe.md template. Added all the suggestions addressed in #10.
Kindly review the changes .Thank you.
- Status changed to Needs work
over 1 year ago 7:18am 25 August 2023 - ๐ฎ๐ณIndia rushiraval
@Anjali Mehta Thanks for your contribution and MR. Now it format is as per Drupal Requirement. But Maintainers section is missing in this MR. So I suggest to add this section with name of maintainers.
- Status changed to Needs review
over 1 year ago 9:25am 25 August 2023 - ๐ฎ๐ณIndia Anjali Mehta
Hello @rushiraval,
Thank you for your review. Please follow step #10, as it was suggested by the maintainer of this module that:
"With every maintainer joining or moving out, this file would require an update; hence, let's ignore."
Additionally, please note that this section is optional, as stated in the Drupal README.md template โ . Therefore, it's not mandatory to include this section in the readme.md file.
Considering this, I'm changing the status back to NR.
Thank you.
- Status changed to RTBC
over 1 year ago 9:31am 25 August 2023 - ๐ฎ๐ณIndia rushiraval
@Anjali Mehta Thanks for your contribution. I have review MR!1 and MR!1 is as per drupal recommendation.
I am changing status to RTBC. -
abhaysaraf โ
committed 101dd41e on 1.0.x authored by
Anjali Mehta โ
Issue #3365045 by Anjali Mehta, Akshay kashyap, abhaysaraf, rushiraval:...
-
abhaysaraf โ
committed 101dd41e on 1.0.x authored by
Anjali Mehta โ
- Status changed to Fixed
over 1 year ago 6:11am 26 August 2023 - ๐ฎ๐ณIndia abhaysaraf
MR-5 merged. Thank you everyone for supporting the module.
Automatically closed - issue fixed for 2 weeks with no activity.