- Issue created by @brockfanning
- Status changed to Needs review
over 1 year ago 9:12pm 2 June 2023 - Status changed to Needs work
over 1 year ago 9:15pm 2 June 2023 - ๐บ๐ธUnited States smustgrave
Should figure out why that value is not there vs just a check.
Donโt want to patch it if thereโs an issue somewhere else
- ๐บ๐ธUnited States brockfanning
That's a good point. My thinking was that that code actually runs whenever you right click on something, anywhere in the editor. So, it works fine when you right click on an accordion. But if you right click on something else (like a table) then those getAscendant calls return "null" and the hasClass calls produce a JS error (since you can't call .hasClass of null).
- ๐บ๐ธUnited States brockfanning
@smustgrave - Does that explanation make sense? If so, then the null values are to be expected, and I think the patch is good as it is.
- @smustgrave opened merge request.
-
smustgrave โ
committed a12edcea on 1.0.x
Issue #3364549: Context menu of other CKEditor buttons not working
-
smustgrave โ
committed a12edcea on 1.0.x
- @smustgrave opened merge request.
-
smustgrave โ
committed ebb8457e on 2.0.x
Issue #3364549: Context menu of other CKEditor buttons not working
-
smustgrave โ
committed ebb8457e on 2.0.x
- Status changed to Fixed
over 1 year ago 1:53pm 8 June 2023 Automatically closed - issue fixed for 2 weeks with no activity.