- Issue created by @BramDriesen
- 🇧🇪Belgium BramDriesen Belgium 🇧🇪
Previous version: 8.x-2.4
Upgraded version: 8.x-3.0-beta2Seems like this creeped in here: https://www.drupal.org/project/config_ignore/issues/3099674#comment-1348... →
- Merge request !16Issue #3364097: A config ignore pattern entry cannot contain both, '~' and '*'. → (Closed) created by BramDriesen
- Status changed to Needs review
over 1 year ago 10:39am 1 June 2023 - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
Wanted to see what the tests results would be with the exception removed. But can't seem to trigger them on the pull request. Uploading the diff to see if that works.
- last update
over 1 year ago 22 pass, 1 fail - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
Okay makes sense that this test case is failing as the exception is removed.
Would love to know why this exception was added in the first place, as it's working fine for us in the 2.x version.
- 🇨🇭Switzerland bircher 🇨🇿
yea I think we need to re-work how the patterns are resolved and matched, or not matched, there are a couple of other issues around it.
I think the reason why you can not have a ~ and a * in the same pattern is that it would confusing which one applies and which one overrides which. but I think we could do the following:
We separate all the patterns with ~ then we find which config to ignore and then remove from the ignore list again. Or since we go through all the config and check if it is ignored: We first check if it matches a pattern starting with ~ and then early return false.But it gets more complicated because we also allow ignoring only certain keys in otherwise not ignored config and there is an issue about allowing to ignore config in certain collections.
So yes re-working this is one of the key points to have a smooth transition between 2.x and 3.x
- 🇧🇪Belgium BramDriesen Belgium 🇧🇪
I think the reason why you can not have a ~ and a * in the same pattern is that it would confusing which one applies and which one overrides which.
Note that the functionality is actually working perfectly fine. At least in our case. We are ignoring all cohesion configs, except the sync packages which are 5 or so config files in our case.
We can't downgrade either because one of our other module dependencies is locking config ignore at 3.x.
- Status changed to Fixed
about 1 year ago 1:50pm 20 October 2023 - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
This was worked on during DrupalCon Lille 🥳 adding the tag!
Automatically closed - issue fixed for 2 weeks with no activity.