Function getWorkflowType doesn't check $workflow before usage

[error] Error: Call to a member function getTypePlugin() on null in Drupal\webform_workflows_element\Service\WebformWorkflowsManager->getWorkflowType() (line 80 of modules/contrib/webform_workflows_element/src/Service/WebformWorkflowsManager.php) #0 modules/contrib/webform_workflows_element/src/Service/WebformWorkflowsManager.php(65): Drupal\webform_workflows_element\Service\WebformWorkflowsManager->getWorkflowType('css_form_flow') #1 modules/contrib/webform_workflows_element/src/Service/WebformWorkflowsManager.php(125): Drupal\webform_workflows_element\Service\WebformWorkflowsManager->getWorkflowTypeFromElement(Array) #2 modules/contrib/webform_workflows_element/src/Element/WebformWorkflowsElement.php(38): Drupal\webform_workflows_element\Service\WebformWorkflowsManager->getInitialStateForElement(Array) #3 modules/contrib/webform/src/Element/WebformCompositeBase.php(209): Drupal\webform_workflows_element\Element\WebformWorkflowsElement::getCompositeElements(Array) #4 modules/contrib/webform/src/Plugin/WebformElement/WebformCompositeBase.php(1276): Drupal\webform\Element\WebformCompositeBase::initializeCompositeElements(Array) #5 modules/contrib/webform/src/Plugin/WebformElement/WebformCompositeBase.php(166): Drupal\webform\Plugin\WebformElement\WebformCompositeBase->initializeCompositeElements(Array)

Comments & Activities

Issue created by @MikaT
Comment over 1 year ago →
🇫🇮Finland MikaT
Patch where the workflow is checked before usage.
Comment over 1 year ago →
🇫🇮Finland MikaT
Updated patch.
Comment over 1 year ago →
🇫🇮Finland MikaT
Updated patch.
Assigned to PrabuEla
Comment over 1 year ago →
🇮🇳India PrabuEla chennai
Comment over 1 year ago →
🇮🇳India PrabuEla chennai
Issue was unassigned.
Status changed to Needs review over 1 year ago2:16pm 1 June 2023
Comment over 1 year ago →
🇮🇳India PrabuEla chennai
Comment over 1 year ago →
maxwellkeeble
There appear to be competing patches here, five minutes apart. Admire the keenness!

I've incorporated both, noting:

- MikaT - re: !$workflow instanceof WebformWorkflowsElement, $workflow would never be the element there, it'd be the Workflow entity itself
- PrabuEla - getStatesFromElement was set to return an array (i.e. was not nullable) - fixed

I've also done the same treatment for any calls to getWorkflowTypeFromElement as that would lead to the same issue.
Status changed to Fixed over 1 year ago11:19am 5 June 2023
Comment over 1 year ago →
System Message

maxwellkeeble → committed 1edd2428 on 1.0.x
Issue #3364048 by MikaT, PrabuEla, maxwellkeeble: Function...
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Function getWorkflowType doesn't check $workflow before usage

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments & Activities