- Issue created by @agentrickard
- Status changed to Needs review
over 1 year ago 4:07pm 28 May 2023 - Open on Drupal.org βCore: 10.1.x + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - πΊπΈUnited States agentrickard Georgia (US)
And a simple patch to kick things off.
- last update
over 1 year ago run-tests.sh fatal error - last update
over 1 year ago 78 pass, 26 fail - πΊπΈUnited States agentrickard Georgia (US)
Updated patch that hopefully fixes the D9 fails.
- last update
over 1 year ago run-tests.sh fatal error - last update
over 1 year ago run-tests.sh fatal error The last submitted patch, 3: 3363211-domain_d10-3.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- Open on Drupal.org βCore: 10.1.x + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - last update
over 1 year ago run-tests.sh fatal error - last update
over 1 year ago 80 pass, 22 fail - last update
over 1 year ago run-tests.sh fatal error The last submitted patch, 6: 3363211-domain_d10-6.patch, failed testing. View results β
- last update
over 1 year ago 91 pass, 4 fail - πΊπΈUnited States agentrickard Georgia (US)
These are all passing for me locally except domain_config_ui.
The Drupal testbot also doesn't like the symfony variance in the middleware test, so that might need to become a service factory.
The last submitted patch, 8: 3363211-domain_d10-8.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago 91 pass, 4 fail - πΊπΈUnited States agentrickard Georgia (US)
Not sure why those patches don't apply...
- last update
over 1 year ago run-tests.sh fatal error - πΊπΈUnited States agentrickard Georgia (US)
Two remaining issues that I see:
1) Domain Config UI JavaScript tests are no longer running as expected.
2) There is a Symfony compatibility change that causes the domain_config_middleware_test to fail on PHP 8. Not sure how to solve that without dropping D9 support.
- Status changed to Needs work
over 1 year ago 4:22pm 29 May 2023 The last submitted patch, 11: 3363211-domain_d10-11.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- Open on Drupal.org βCore: 10.1.x + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - πΊπΈUnited States agentrickard Georgia (US)
I think I solved problem #1.
- Status changed to Needs review
over 1 year ago 6:08pm 30 May 2023 - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply The last submitted patch, 11: 3363211-domain_d10-11.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago 91 pass, 4 fail - πΊπΈUnited States agentrickard Georgia (US)
Made the patch against the wrong branch.
- last update
over 1 year ago run-tests.sh fatal error The last submitted patch, 17: 3363211-domain_d10-17.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- last update
over 1 year ago run-tests.sh fatal error - last update
over 1 year ago 91 pass, 4 fail - last update
over 1 year ago 82 pass, 18 fail The last submitted patch, 19: 3363211-domain_d10-19.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- last update
over 1 year ago 91 pass, 4 fail - πΊπΈUnited States agentrickard Georgia (US)
More backwards-compat stuff.
- last update
over 1 year ago 93 pass The last submitted patch, 21: 3363211-domain_d10-21.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- last update
over 1 year ago 91 pass, 4 fail - last update
over 1 year ago 92 pass, 2 fail The last submitted patch, 23: 3363211-domain_d10-23.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- last update
over 1 year ago 93 pass - last update
over 1 year ago 93 pass - last update
over 1 year ago 93 pass - Status changed to RTBC
over 1 year ago 2:52pm 2 June 2023 - πΊπΈUnited States agentrickard Georgia (US)
WOOOOOOOO!
Any reviewers?
- last update
over 1 year ago run-tests.sh fatal error - Status changed to Fixed
over 1 year ago 3:50pm 6 June 2023 - πΊπΈUnited States agentrickard Georgia (US)
This has been committed, paving the way for 2.0.0-beta1 once branch tests pass.
Automatically closed - issue fixed for 2 weeks with no activity.