Contrib.social

Fix not styled Gin admin theme accent while installing. As no user Gin setting yet and no user service yet, and some libraries are not loading on the install

Open on Drupal.org →
Created on 28 May 2023, over 1 year ago
Updated 29 May 2023, over 1 year ago

Problem/Motivation

Some libraries are not loading on the install

🐛 Fix user.data ServiceNotFoundException when using Gin as distribution installer theme Fixed

Facing the following issue When I click on "Save and continue"
and move to the next installation step

Additional uncaught exception thrown while handling exception.
Original
Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: You have requested a non-existent service "user.data". in Symfony\Component\DependencyInjection\ContainerBuilder->getDefinition() (line 1030 of /var/www/html/dev/v10c15/vendor/symfony/dependency-injection/ContainerBuilder.php).

Symfony\Component\DependencyInjection\ContainerBuilder->getDefinition() (Line: 600)
Symfony\Component\DependencyInjection\ContainerBuilder->doGet() (Line: 558)
Symfony\Component\DependencyInjection\ContainerBuilder->get() (Line: 62)
Drupal\gin\GinSettings::create() (Line: 28)
Drupal\Core\DependencyInjection\ClassResolver->getInstanceFromDefinition() (Line: 364)
Drupal::classResolver() (Line: 21)
gin_preprocess_html()
call_user_func_array() (Line: 287)
Drupal\Core\Theme\ThemeManager->render() (Line: 422)
Drupal\Core\Render\Renderer->doRender() (Line: 201)
Drupal\Core\Render\Renderer->render() (Line: 145)
Drupal\Core\Render\Renderer->Drupal\Core\Render\{closure}() (Line: 564)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 146)
Drupal\Core\Render\Renderer->renderRoot() (Line: 66)
Drupal\Core\Render\BareHtmlPageRenderer->renderBarePage() (Line: 76)
Drupal\Core\ProxyClass\Render\BareHtmlPageRenderer->renderBarePage() (Line: 1058)
install_display_output() (Line: 161)
install_drupal() (Line: 48)

The issue of missing Accent color
Basic default accent color
I'm with loading/attaching the gin_accent basic default library been loaded in the install-page.html.twig
To let the accent.js set the --gin-color-primary from gin.settings
or a fallback default in js

Having a null value for the preset_accent_color or no gin.settings
When it has preset_accent_color: blue in the config.

Maybe a gin_preprocess_install_page is needed with minimal load for install.
to do things like gin_preprocess_html or gin_page_attachments_alter

Proposed resolution

Quick fix for this with custom --gin-color-primary accent

Not to load not styled gin accent while installing.
As no user Gin setting yet and no user service yet.

having the patch and having the following

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ✅ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release varbase-10.0.0-alpha1 → , vartheme_claro-4.0.0-alpha3 →

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3363196 → : Fixed not styled Gin admin theme accent while installing. As no user Gin setting yet and no user service yet, and some libraries are not loading on the install
📌 Task
Status

Fixed

Version

4.0

Component

Code

Created by

🇯🇴Jordan Rajab Natshah Jordan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024