Unnecessary grey background on logo

Created on 26 May 2023, almost 2 years ago
Updated 30 May 2023, almost 2 years ago

Problem/Motivation

It seems there is a grey background set for the Evolving Web logo on following pages in the "Thank you to our training partners!" section.

https://www.drupal.org/association/discover-drupal β†’
https://www.drupal.org/association/discover-drupal/details β†’
https://www.drupal.org/association/discover-drupal/support-the-program β†’

A few logo's below that, the same logo appears without the grey background. To me the grey background seems unnecessary.

Steps to reproduce

Visit the urls above.

This seems to be caused by the extra styling added to .nonary-second in bluecheese/sass/partials/drupalorg/_section-marketing.scss

Proposed resolution

Remove the grey background

Remaining tasks

Pull request

User interface changes

N/A (besides style change)

πŸ“Œ Task
Status

Active

Version

1.0

Component

Other

Created by

πŸ‡§πŸ‡ͺBelgium BramDriesen Belgium πŸ‡§πŸ‡ͺ

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @BramDriesen
  • @bramdriesen opened merge request.
  • Status changed to Needs review almost 2 years ago
  • πŸ‡§πŸ‡ͺBelgium BramDriesen Belgium πŸ‡§πŸ‡ͺ

    I saw that part of the CSS is also used for cases studies (pane-bundle-case-study and CTA's) but couldn't find this anywhere on Drupal.org on the 30 or so pages I checked.

  • πŸ‡ͺπŸ‡ΈSpain fjgarlin

    I'm not sure if this pane layout is used in other parts of the site. According to the code it can potentially be used in documentation/guide pages, project release pages and perhaps some other places, but I'm not sure if it's actually being used on those.

    I'll let @drumm make the call as he might be more familiar with the places where this is used.

  • πŸ‡ͺπŸ‡ΈSpain fjgarlin

    Having said the above, there seems to be an empty grid with that layout on some pages, which shows the grey background cell with nothing in it. The MR would fix that, even though it seems to be empty content in those cases.

    See the screenshots:
    - Empty block with grey background 1 β†’
    - Empty block with grey background 2 β†’

  • πŸ‡§πŸ‡ͺBelgium BramDriesen Belgium πŸ‡§πŸ‡ͺ

    Yeah, I visited quite a lot of different page types, but couldn't really find any usage of the same element. But then again, I'm not familiar with all the content and how it's set-up πŸ˜‰ so I guess someone like @drumm has more knowledge about that.

  • πŸ‡ΊπŸ‡ΈUnited States drumm NY, US

    This is by design, the industry landing pages use it, like https://www.drupal.org/industries/retail β†’ . But that does end up being reused as a generic, sometimes non-ideal, way to put things into 3 columns. We have a couple other options for displaying logos that might be a better fit.

  • Status changed to Active almost 2 years ago
  • πŸ‡ΊπŸ‡ΈUnited States drumm NY, US

    This is probably the best place to track using something else to display those panes.

Production build 0.71.5 2024