- Issue created by @Ryo Yamashita
- last update
over 1 year ago 366 pass - @ryo-yamashita opened merge request.
- Status changed to Needs review
over 1 year ago 6:04am 26 May 2023 - Status changed to Needs work
over 1 year ago 6:14am 26 May 2023 - πΊπΈUnited States yas California πΊπΈ
@ryo-yamashita
Thank you for the patch. I left my comment. Thanks!
- last update
over 1 year ago 366 pass - Status changed to Needs review
over 1 year ago 7:11am 26 May 2023 - π―π΅Japan Ryo Yamashita
@yas
I fixed the patch for your comments. Thanks.
- Status changed to RTBC
over 1 year ago 7:22am 26 May 2023 - πΊπΈUnited States yas California πΊπΈ
@ryo-yamashita
Thank you for the update. I'll merge the patch to
5.x
and6.x
, and close this issue as Fixed. - last update
over 1 year ago 366 pass -
yas β
committed 987efebd on 6.x authored by
Ryo Yamashita β
Issue #3362829 by Ryo Yamashita, yas: Fix an issue where the OpenStack...
-
yas β
committed 987efebd on 6.x authored by
Ryo Yamashita β
-
yas β
committed d1146836 on 5.x authored by
Ryo Yamashita β
Issue #3362829 by Ryo Yamashita, yas: Fix an issue where the OpenStack...
-
yas β
committed d1146836 on 5.x authored by
Ryo Yamashita β
- Status changed to Needs work
over 1 year ago 7:27am 26 May 2023 - πΊπΈUnited States yas California πΊπΈ
@ryo-yamashita
Sorry, I've merged the patch w/ some error: https://www.drupal.org/pift-ci-job/2676588 β . Can you please create the hotfix for
drupal/cloud6.x-dev
?I guess that it is related to the following:
.../cloud_dashboard/src/organisms/PageTitle.tsx | 16 +++++- modules/cloud_dashboard/js/index.js | 51 +++++++++++--------- 2 files changed, 42 insertions(+), 25 deletions(-) 1801.diff:41: trailing whitespace. (function(){const t=document.createElement("link").relList;if(t&&t.supports&&t.supports("modulepreload"))return;for(const i of ... (snip) ... day");Drupal.t("Monitor");Drupal.t("Monitoring");Drupal.t("Monthly");Drupal.t(`More than one elastic IP can appear in the email message. Available warning: 2 lines add whitespace errors.
- Status changed to Fixed
over 1 year ago 9:24pm 29 May 2023 - πΊπΈUnited States yas California πΊπΈ
@ryo-yamashita
Let us close this issue since the coding standard errors should be handled in the other issue.
Thanks
Automatically closed - issue fixed for 2 weeks with no activity.