PHPStan warnings regarding dependency injection issues

------ ---------------------------------------------------------------------- Line src/Asset/AssetDumper.php ------ ---------------------------------------------------------------------- 29 \Drupal calls should be avoided in classes, use dependency injection instead 30 \Drupal calls should be avoided in classes, use dependency injection instead 41 \Drupal calls should be avoided in classes, use dependency injection instead 42 \Drupal calls should be avoided in classes, use dependency injection instead ------ ---------------------------------------------------------------------- ------ ---------------------------------------------------------------------- Line src/Asset/CssCollectionOptimizer.php ------ ---------------------------------------------------------------------- 22 \Drupal calls should be avoided in classes, use dependency injection instead 25 \Drupal calls should be avoided in classes, use dependency injection instead 26 \Drupal calls should be avoided in classes, use dependency injection instead ------ ---------------------------------------------------------------------- ------ ---------------------------------------------------------------------- Line src/Asset/JsCollectionOptimizer.php ------ ---------------------------------------------------------------------- 22 \Drupal calls should be avoided in classes, use dependency injection instead 25 \Drupal calls should be avoided in classes, use dependency injection instead 26 \Drupal calls should be avoided in classes, use dependency injection instead ------ ---------------------------------------------------------------------- ------ --------------------------------------- Line src/Plugin/FlysystemPluginManager.php ------ --------------------------------------- 13 Plugin definitions cannot be altered. ------ ---------------------------------------

Comments & Activities

Issue created by @lhridley
Issue was unassigned.
Comment about 1 year ago →
🇺🇸United States lhridley
Assigned to vishal365365
Comment about 1 year ago →
🇮🇳India vishal365365
Issue was unassigned.
Status changed to Needs work 12 months ago3:47pm 12 July 2023
Comment 12 months ago →
🇮🇳India roshni27
Hi,
Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig flysystem/
Branch : 2.1.x
PHP Version : 8.1
There are no errors related to dependency injection.
Some minor code standard issues which encounter when execute above command and I have found Drupal 10 compatibility issue.
I am working on it.
Status changed to Needs review 12 months ago3:57pm 12 July 2023
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7
last update 12 months ago
103 pass
Comment 12 months ago →
🇮🇳India roshni27
Please review patch.
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7
last update 11 months ago
103 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 8
last update 11 months ago
103 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7
last update 11 months ago
Patch Failed to Apply
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 8
last update 11 months ago
Patch Failed to Apply
Status changed to Closed: outdated 11 months ago7:40pm 30 July 2023
Comment 11 months ago →
🇺🇸United States lhridley
Closing as outdated. Some dependency injection issues were fixed in other MRs, some still remain, new issue will be opened to address remaining dependency injection issues as well as deprecated functionality for Drupal 11.

PHPStan warnings regarding dependency injection issues

Problem/Motivation

Comments & Activities