Microsite menu links always appear in original language

Here's a patch. I haven't had a chance to look into test coverage.

The last submitted patch, 2: micrsite-menu-translation-3362780-2.patch, failed testing. View results →

Those failures are both related to the patch not handling overrides correctly. Hrm...

How does one allow translation and allow title overrides? That may be tricky.

Here's a shot at supporting overrides and translated node titles. This requires more changes than I would like but I think it works.

The latest patch offers what I would consider a bonus improvement.

Currently, if I use the menu link override form to change a link's weight, say, the node title at that moment gets saved as the menu link override title. From that point onward if I change the node title the microsite menu link will continue showing that old title because it's saved to the override entity.

With the latest patch, setting the menu link override label to an empty string allows the override to continue honoring the node title.

It needs some love from a UX standpoint. I would rather the override form load with an empty string as the label until you save the override with a label.

+++ b/modules/entity_hierarchy_microsite/src/Plugin/Menu/MicrositeMenuItem.php
@@ -194,7 +194,21 @@ class MicrositeMenuItem extends MenuLinkBase implements ContainerFactoryPluginIn
+    $node = $this->entityTypeManager->getStorage('node')->load($this->pluginDefinition['metadata']['entity_id']);
+    $language = \Drupal::languageManager()->getCurrentLanguage()->getId();
+    if (!empty($node) && $node->hasTranslation($language)) {

Do default menu links work this way? It feels like a performance issue to be loading a single node and its translation for each menu link.

It does a loadMultiple by way of \Drupal\menu_link_content\Plugin\Menu\MenuLinkContent::__construct and a static property.

Not great but I think still performant than what we're doing here.

Needs work to try and emulate the load multiple approach.

We do have an advantage here in that we can query the tree to get all the entity IDs using the EH api.

Hi @larowlan. As always, thank you for the thoughtful review. :)

I'm still trying to grok the load multiple stuff going on in MenuLinkContent. I don't have any performance improvements in here.

I'm posting an updated patch that deals with a lingering bug or two. For better or worse, I'm trying to use the absence of the title on the plugin definition as a signal that the node's title should be used as the link title. The patch here makes sure that (1) the discovery does not set the title, (2) the add override form does not populate the title field automatically, (3) the edit override form has a helpful title even if the override does not have a title.

This patch breaks the update test (which I didn't feel like fixing right now). It also caused an assertion in the admin tests to fail. I updated the failing assertion based on updated expectations and I also added a bit of coverage. This doesn't cover translation yet, but it covers the idea of an empty plugin or override title indicating that the node title should be used.

I'm setting to NR to trigger tests. The update tests will fail, kicking this back to NW, which is the correct status.

The last submitted patch, 10: microsite-menu-translation-3362780-10.patch, failed testing. View results →