Contrib.social

Update minimum Node.js version for Vartheme Claro to >=18, SASS, PostCSS, and Webpack version to ~5. With preloaded and adopted --gin-font for RTL

Open on Drupal.org →
Created on 25 May 2023, over 1 year ago
Updated 29 May 2023, over 1 year ago

Problem/Motivation

📌 Require Node.js 18 for development in 10.1.x Fixed

Proposed resolution

  • Align Varbase 10.0.x with the efforts of the Drupal core team for Drupal 10.1.x by updating the minimum Node.js version to >=18.
  • Switch to Webpack ~5.0
  • Drop Gulp in favor of Webpack, SASS, and PostCSS
  • Use preload for the RTL font
  • Change the following for the --gin-font for RTL and adopt the RTL font to the Gin design
    	[dir=rtl]:root {
	  --gin-font: "Tajawal", sans-serif;
	  --gin-font-size-xxs: .75rem;
	  --gin-font-size-xs: small;
	  --gin-font-size-s: .875rem;
	  --gin-font-size: 1rem;
	  --gin-font-size-m: var(--gin-font-size);
	  --gin-font-size-l: 1.125rem;
	  --gin-font-size-xl: 1.25rem;
	  --gin-font-size-h3: 1.5rem;
	  --gin-font-size-h2: 1.75rem;
	  --gin-font-size-h1: 1.6rem;
	  --gin-font-size-quote: 1.1em;
	  --gin-font-weight-normal: 500;
	  --gin-font-weight-semibold: 626;
	  --gin-font-weight-bold: 600;
	  --gin-font-weight-heavy: 700;
	}

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ✅ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release varbase-10.0.0-alpha1 → , vartheme_claro-4.0.0-alpha2 →

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3362682: Updated minimum Node.js version for Vartheme Claro to >=18, SASS, PostCSS, and Webpack version to ~5. With preloaded and adopted --gin-font for RTL
📌 Task
Status

Fixed

Version

4.0

Component

Code

Created by

🇯🇴Jordan Rajab Natshah Jordan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024