RC1: Can't add more than one digital product to cart

Confirmed same issue here. A dealbreaker.

Cause is somewhere in https://www.drupal.org/project/commerce_license/issues/2943888 ✨ Add the ability to re-purchase a license to extend it Fixed .

Urgh. I did think ✨ Add the ability to re-purchase a license to extend it Fixed was a can of worms.

> "Removed product#2 as product#1 already grants the same license".

The products should know that they're not for the same file.

Thanks for the report!

Will get on this issue ASAP.

The feature to add extendable licenses added a validation to prevent multiple instances of the same renewable license to the cart.

This validation was too broad, as the logic was applied to ALL licenses, renewable or not. It also was checking the license type, rather than the purchased entity.

This has been addressed.

I switched to PHP 8.1.19 + commerce_license 8.x-2.0-rc4 and I have this error now when I'm adding more than 1 product : Nesting level too deep - recursive dependency? modules/contrib/commerce_license/src/LicenseOrderProcessorMultiples.php on line 113

Hi @laurentwh. Thanks for the feedback.

Not able to reproduce this in a local environment, but I suspect you might have a more complex purchasable_entity. (Possibly with circular references.)

Can you try changing line 113 in LicenseOrderProcessorMultiples.php from:

        if (in_array($purchased_entity, $purchased_entities)) {

to

        if (in_array($purchased_entity, $purchased_entities, TRUE)) {

and LMK if that resolves it for you?

Tanks a lot Tom. I switched back to PHP 8.0 as PHP 8.1 brought a lot more errors on other modules. No more error yet with a lot heavy tests on your 8.2-RC4 module + Commerce File.

@laurentwh rc5 has been tagged with a more efficient in_array check that should address the issue you encountered.

Tested and working fine on Drupal 9.5.9 + Commerce File + Commerce license - PHP 8.1.20. Thanks again @TomTech

Automatically closed - issue fixed for 2 weeks with no activity.