Access verification is incorrect

Here's a patch to solve it

Based on the test failures and my knowledge of the access() method, you may not be correct. There is an additional argument that must be set to TRUE in order to get an object returned back, both in the case of Url::access() and EntityInterface::access() which we do not use:

        $access = $url->access($this->anonymousUser);
      }
      else {
        $loc = ($entity->id() && $entity->hasLinkTemplate('canonical')) ? $entity->toUrl()->getInternalPath() : '';
        $access = $entity->access('view', $this->anonymousUser);

Sorry for the delay, i was a bit busy.

I use bundle classes to add specific access to my bundle under some circumtances.

Without my patch, i must return FALSE in ACCESS method to remove it from sitemap.xml

But if i return FALSE, i got this error

Drupal\Core\Access\AccessException: Access error in access_check.entity. Access services must return an object that implements AccessResultInterface. in Drupal\Core\Access\AccessManager->performCheck() (line 163 of core/lib/Drupal/Core/Access/AccessManager.php).

I think it's dumb because access method is suppose to return boolean (as php doc suggest).
But i think it's easier to fix a module core that the core itself.

Here's my code.
Maybe you will understand better

@arnaud-burgnon: Your implementation needs to consider the API of what you are doing and the $return_as_object parameter. You should not *only* be returning a boolean, but it should return an object or a boolean depending on that parameter.

I think if you adjusted your code to return a boolean if $return_as_object is FALSE, or an AccessResultInterface if $return_as_object is TRUE will avoid other errors, not just with the XML sitemap module. What we are doing in the module is correct, the issue is the code custom access method. I'd love to hear back if you can update it and and test again to confirm this.

Damn.
Indeed, it was my mistake.
I closed it.