CustomElementFormatter plugin type for entity_ce_display

Created on 25 May 2023, about 1 year ago
Updated 9 May 2024, about 1 month ago

Problem/Motivation

After multiple discussions, we agreed that the recently introduced entity_ce_display deserves to have its own plugin type.

Proposed resolution

  • introduce new plugin type in addition to formatters with name(annotation) CustomElementFormatter;
  • make plugin type not configurable;
  • have attribute to decide whether it uses field formatters or not; usesFieldFormatters
  • in UI display only select with options;
  • default plugins in a module are:
    • auto
    • raw
    • formatted
  • show in new column next to "isSlot", dropdown of CE-formatters. Try to make field-formatters drop-down disabled based upon "usesFieldFormatters" value of the selected plugin
  • plugin adds data to custom-element object given the configruation (name)
  • it thus can use string|MarkupInterface for adding a slot, or a single CE or an array of CE objects
    • raw plugin with toArray() might need something like var_export() to map to String
    • if not a slot, passing an array is fine
πŸ“Œ Task
Status

Fixed

Version

3.0

Component

User interface

Created by

πŸ‡ΊπŸ‡¦Ukraine mostepaniukvm

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @mostepaniukvm
  • Assigned to mostepaniukvm
  • Open on Drupal.org β†’
    Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
    last update 8 months ago
    Not currently mergeable.
  • Open in Jenkins β†’ Open on Drupal.org β†’
    Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
    last update 8 months ago
    6 pass
  • Open in Jenkins β†’ Open on Drupal.org β†’
    Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
    last update 8 months ago
    1 pass, 3 fail
  • Open in Jenkins β†’ Open on Drupal.org β†’
    Core: 10.2.1 + Environment: PHP 8.2 & MySQL 8
    last update 3 months ago
    1 pass, 3 fail
  • Issue was unassigned.
  • Status changed to Needs work 3 months ago
  • πŸ‡¦πŸ‡ΉAustria fago Vienna

    ok, this one needs some more work and possibly discussion. I've added my remarks to the WIP code.
    @junkuncz Please take a look and then let's discuss!

  • First commit to issue fork.
  • Pipeline finished with Failed
    3 months ago
    Total: 259s
    #129688
  • Pipeline finished with Failed
    3 months ago
    Total: 160s
    #129744
  • Pipeline finished with Failed
    3 months ago
    Total: 208s
    #129759
  • Pipeline finished with Failed
    3 months ago
    Total: 171s
    #129767
  • Pipeline finished with Failed
    3 months ago
    Total: 232s
    #130334
  • Pipeline finished with Failed
    3 months ago
    Total: 173s
    #130341
  • Pipeline finished with Failed
    3 months ago
    Total: 170s
    #130347
  • Pipeline finished with Failed
    3 months ago
    Total: 239s
    #130455
  • Pipeline finished with Failed
    3 months ago
    Total: 206s
    #130462
  • Pipeline finished with Failed
    3 months ago
    Total: 321s
    #135086
  • Pipeline finished with Failed
    3 months ago
    #135414
  • Pipeline finished with Failed
    3 months ago
    Total: 200s
    #135418
  • Pipeline finished with Canceled
    3 months ago
    Total: 17s
    #135450
  • Pipeline finished with Canceled
    3 months ago
    Total: 118s
    #135451
  • Pipeline finished with Canceled
    3 months ago
    Total: 55s
    #135452
  • Pipeline finished with Canceled
    3 months ago
    Total: 80s
    #135453
  • Pipeline finished with Failed
    3 months ago
    Total: 211s
    #135456
  • Pipeline finished with Failed
    3 months ago
    Total: 173s
    #135467
  • Pipeline finished with Canceled
    3 months ago
    Total: 91s
    #135497
  • Pipeline finished with Failed
    3 months ago
    #135501
  • Pipeline finished with Failed
    3 months ago
    #135513
  • Pipeline finished with Failed
    3 months ago
    Total: 229s
    #135523
  • Pipeline finished with Failed
    3 months ago
    Total: 180s
    #135532
  • Pipeline finished with Failed
    2 months ago
    Total: 173s
    #137206
  • Pipeline finished with Failed
    2 months ago
    Total: 171s
    #137228
  • πŸ‡³πŸ‡±Netherlands roderik Amsterdam,NL / Budapest,HU

    roderik β†’ changed the visibility of the branch 3362625-customelementformatter-plugin-type to hidden.

  • πŸ‡³πŸ‡±Netherlands roderik Amsterdam,NL / Budapest,HU

    roderik β†’ changed the visibility of the branch 3362625-customelementformatter-plugin-type to hidden.

  • Pipeline finished with Failed
    2 months ago
    Total: 202s
    #137441
  • Pipeline finished with Failed
    2 months ago
    Total: 354s
    #137481
  • Pipeline finished with Failed
    2 months ago
    Total: 172s
    #140875
  • Pipeline finished with Failed
    2 months ago
    Total: 232s
    #140934
  • Pipeline finished with Failed
    2 months ago
    #140951
  • Pipeline finished with Failed
    2 months ago
    Total: 174s
    #141594
  • Pipeline finished with Canceled
    2 months ago
    Total: 33s
    #141601
  • Pipeline finished with Failed
    2 months ago
    Total: 172s
    #141603
  • Pipeline finished with Failed
    2 months ago
    Total: 173s
    #141703
  • Pipeline finished with Failed
    2 months ago
    Total: 208s
    #141813
  • Pipeline finished with Failed
    2 months ago
    Total: 228s
    #141899
  • Pipeline finished with Failed
    2 months ago
    Total: 312s
    #141914
  • Pipeline finished with Failed
    2 months ago
    Total: 201s
    #142498
  • Pipeline finished with Failed
    2 months ago
    Total: 199s
    #142519
  • Pipeline finished with Failed
    2 months ago
    Total: 203s
    #142654
  • Pipeline finished with Canceled
    2 months ago
    Total: 104s
    #142668
  • Pipeline finished with Failed
    2 months ago
    Total: 177s
    #142670
  • Pipeline finished with Failed
    2 months ago
    Total: 255s
    #142695
  • Pipeline finished with Failed
    2 months ago
    Total: 173s
    #142767
  • Pipeline finished with Failed
    2 months ago
    Total: 200s
    #142802
  • πŸ‡­πŸ‡ΊHungary junkuncz

    junkuncz β†’ changed the visibility of the branch 3362625-customelementformatter-plugin-type to active.

  • πŸ‡­πŸ‡ΊHungary junkuncz

    junkuncz β†’ changed the visibility of the branch new-ce-formatter to hidden.

  • πŸ‡­πŸ‡ΊHungary junkuncz

    junkuncz β†’ changed the visibility of the branch 3.x to hidden.

  • πŸ‡­πŸ‡ΊHungary junkuncz

    junkuncz β†’ changed the visibility of the branch 8.x-2.x to hidden.

  • πŸ‡­πŸ‡ΊHungary junkuncz

    junkuncz β†’ changed the visibility of the branch 3359601-re-implement-with-new-concept to hidden.

  • Pipeline finished with Failed
    2 months ago
    Total: 229s
    #143612
  • πŸ‡¦πŸ‡ΉAustria fago Vienna

    First step:
    * Ship with auto and raw formatters

    Follow-ups we need:
    * Add support for field formatters
    * Add UI for configuring CE-formatters
    * Fix support for entity-prepare view step

  • Pipeline finished with Failed
    2 months ago
    Total: 171s
    #143885
  • Pipeline finished with Failed
    2 months ago
    Total: 165s
    #143894
  • Pipeline finished with Failed
    2 months ago
    #143906
  • Pipeline finished with Failed
    2 months ago
    Total: 173s
    #144027
  • Pipeline finished with Failed
    2 months ago
    Total: 176s
    #144054
  • Pipeline finished with Failed
    2 months ago
    Total: 231s
    #144116
  • Pipeline finished with Failed
    2 months ago
    Total: 167s
    #144759
  • Pipeline finished with Failed
    2 months ago
    Total: 167s
    #144766
  • Pipeline finished with Failed
    2 months ago
    #144768
  • Pipeline finished with Success
    about 2 months ago
    Total: 173s
    #150930
  • Pipeline finished with Success
    about 2 months ago
    Total: 172s
    #150944
  • Status changed to Needs review about 2 months ago
  • πŸ‡³πŸ‡±Netherlands roderik Amsterdam,NL / Budapest,HU

    New MR for cleanup.

    I have a question about enabled/disabled CE displays (in the comments).

  • Pipeline finished with Failed
    about 2 months ago
    Total: 179s
    #151213
  • Pipeline finished with Success
    about 2 months ago
    Total: 197s
    #151935
  • Status changed to Needs work about 2 months ago
  • πŸ‡³πŸ‡±Netherlands roderik Amsterdam,NL / Budapest,HU

    Setting back to Needs Work because of questions I have, that I'd probably like to address first -- and outside this issue queue is likely faster.

  • Pipeline finished with Failed
    about 2 months ago
    Total: 173s
    #153656
  • Pipeline finished with Success
    about 2 months ago
    Total: 178s
    #153663
  • Status changed to Needs review about 2 months ago
  • πŸ‡³πŸ‡±Netherlands roderik Amsterdam,NL / Budapest,HU

    ..And then all the answers to the questions I had, seeped into my head overnight.

    This is now changed, documented and for review again. I removed many of the earlier comments and questions I had earlier, from the MR. So only relevant comments are on there now.

  • Pipeline finished with Success
    about 2 months ago
    Total: 173s
    #153746
  • Pipeline finished with Success
    about 2 months ago
    Total: 206s
    #153762
  • Pipeline finished with Success
    about 2 months ago
    Total: 209s
    #154075
  • Status changed to Needs work about 2 months ago
  • πŸ‡¦πŸ‡ΉAustria fago Vienna

    @roderik

    thanks, merged the tests-PR. This ticket got long and massive, let's add sub-tasks/issues for remaining/next steps?
    I've left some non-blocking comments above, let's move any action items in sub-tasks/follow-up also, like one for the update path.

    Setting to needs work for that, but when all follow-up/sub-tasks are added I think we can close this first one.

  • Status changed to Fixed about 2 months ago
  • πŸ‡³πŸ‡±Netherlands roderik Amsterdam,NL / Budapest,HU

    Followup(s):

    created πŸ› Update path and documentation Active

    modified πŸ“Œ Fix editing UI for CE displays / make default display disable-able Active to be about the UI

    There are some comments in the MR to be addressed, but that's clearly noted in the followup(s), so indeed, we can close this.

    (Also updated the list in 🌱 [META] custom_elements_ui: 3.x alpha release Active

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024