- Issue created by @mostepaniukvm
- Assigned to mostepaniukvm
- Merge request !29Issue #3362625: CustomElementFormatter plugin type for entity_ce_display β (Merged) created by mostepaniukvm
- Open on Drupal.org βCore: 10.1.4 + Environment: PHP 8.2 & MySQL 8last update
about 1 year ago Not currently mergeable. - last update
about 1 year ago 6 pass - last update
about 1 year ago 1 pass, 3 fail - πΊπ¦Ukraine mostepaniukvm
diff link to unmerged related issue
https://git.drupalcode.org/issue/custom_elements-3362625/-/compare/33596... - last update
9 months ago 1 pass, 3 fail - Issue was unassigned.
- Status changed to Needs work
9 months ago 6:19am 5 March 2024 - π¦πΉAustria fago Vienna
ok, this one needs some more work and possibly discussion. I've added my remarks to the WIP code.
@junkuncz Please take a look and then let's discuss! - First commit to issue fork.
- π³π±Netherlands roderik Amsterdam,NL / Budapest,HU
roderik β changed the visibility of the branch 3362625-customelementformatter-plugin-type to hidden.
- π³π±Netherlands roderik Amsterdam,NL / Budapest,HU
roderik β changed the visibility of the branch 3362625-customelementformatter-plugin-type to hidden.
- ππΊHungary junkuncz
junkuncz β changed the visibility of the branch 3362625-customelementformatter-plugin-type to active.
- ππΊHungary junkuncz
junkuncz β changed the visibility of the branch new-ce-formatter to hidden.
- ππΊHungary junkuncz
junkuncz β changed the visibility of the branch 3.x to hidden.
- ππΊHungary junkuncz
junkuncz β changed the visibility of the branch 8.x-2.x to hidden.
- ππΊHungary junkuncz
junkuncz β changed the visibility of the branch 3359601-re-implement-with-new-concept to hidden.
- π¦πΉAustria fago Vienna
First step:
* Ship with auto and raw formattersFollow-ups we need:
* Add support for field formatters
* Add UI for configuring CE-formatters
* Fix support for entity-prepare view step -
fago β
committed 65d56d71 on 3.x authored by
mostepaniukvm β
Issue #3362625 by mostepaniukvm, junkuncz: Add...
-
fago β
committed 65d56d71 on 3.x authored by
mostepaniukvm β
- Merge request !40Issue #3362625 by roderik: Improve and fix tests for v3 β (Merged) created by roderik
- Status changed to Needs review
7 months ago 12:44pm 19 April 2024 - π³π±Netherlands roderik Amsterdam,NL / Budapest,HU
New MR for cleanup.
I have a question about enabled/disabled CE displays (in the comments).
- Status changed to Needs work
7 months ago 3:52pm 21 April 2024 - π³π±Netherlands roderik Amsterdam,NL / Budapest,HU
Setting back to Needs Work because of questions I have, that I'd probably like to address first -- and outside this issue queue is likely faster.
- Status changed to Needs review
7 months ago 9:21pm 22 April 2024 - π³π±Netherlands roderik Amsterdam,NL / Budapest,HU
..And then all the answers to the questions I had, seeped into my head overnight.
This is now changed, documented and for review again. I removed many of the earlier comments and questions I had earlier, from the MR. So only relevant comments are on there now.
-
fago β
committed 42eb74c4 on 3.x authored by
roderik β
Issue #3362625 by roderik: Improve and fix tests for v3
-
fago β
committed 42eb74c4 on 3.x authored by
roderik β
- Status changed to Needs work
7 months ago 9:09am 23 April 2024 - π¦πΉAustria fago Vienna
@roderik
thanks, merged the tests-PR. This ticket got long and massive, let's add sub-tasks/issues for remaining/next steps?
I've left some non-blocking comments above, let's move any action items in sub-tasks/follow-up also, like one for the update path.Setting to needs work for that, but when all follow-up/sub-tasks are added I think we can close this first one.
- Status changed to Fixed
7 months ago 10:28am 25 April 2024 - π³π±Netherlands roderik Amsterdam,NL / Budapest,HU
Followup(s):
created π Update path and documentation Active
modified π Fix editing UI for CE displays / make default display disable-able Active to be about the UI
There are some comments in the MR to be addressed, but that's clearly noted in the followup(s), so indeed, we can close this.
(Also updated the list in π± [META] custom_elements_ui: 3.x alpha release Active
Automatically closed - issue fixed for 2 weeks with no activity.