- Issue created by @junkuncz
- 🇦🇹Austria fago Vienna
So when a view-mode is layout-builder enabled, it should be rendered via this code, not via the new configuration. I think the rendering path is easy / given to solve, but what we probably want to indicate that in the UI as well IF settings are not taking effect since layout builder is taking over.
- 🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU
I'm emptying out this issue's description, and just going from the last comment.
Indeed we need to
indicate that in the UI as well IF settings are not taking effect since layout builder is taking over
but per https://git.drupalcode.org/project/custom_elements/-/merge_requests/40#n... that can be done also by hiding the CE display altogether.
This is true...
(I first thought "but some code could still be using it". Well that's technically true, but who would configure a CE display with the same view mode name as one that is taken over by Layout builder? That's just dumb.)
...but likely not hide the default, if the default is taken over by Layout Builder?For the rest:
- I think we probably need to give some message if the default view mode is disabled.
- The checkboxes for enabling/disabling view modes need to work the same as with 'normal' display modes. When I tested, they were not working.
- And unlike 'normal' displays, there needs to also be a checkbox to disable the default! This is an alpha-blocker.
- Status changed to Needs work
8 months ago 7:58am 30 April 2024 - 🇦🇹Austria fago Vienna
hmm. what is the use-case of disabling the default disable? I think we should simply disallow it.
thus changing issue title back. I think we should do the following here:
* Clarify how disable entity displays works and should work. Afaik there is no UI/feature to disable them in core? or is it the toggle of enabling/hiding the display tab of a view-mode config that enables/disables it? I think we should simply follow core here and to the same.
* Default display. Let's follow core and NOT allow disabling a default default display.
*
> indicate that in the UI as well IF settings are not taking effect since layout builder is taking overAgain, let's follow core. When the layout-builder is enabled for the view-mode, we should hide the regular form view mode and point the layout-builder settings, like core does.
- 🇭🇺Hungary junkuncz Budapest
Changes:
- CE display is prepared for the case when layout_builder module is enabled (hidden form + "Manage Layout" button)
- Views modes are following core approach so "default" one cannot be deleted
- Broken access handler for CE display is fixed - 🇦🇹Austria fago Vienna
thx, changes work well, so merged.
But I think the sole button is not good UX. We need to explain the user why the button is there. Something like
"Layout builder is enabled for this view mode. Thus, the configured layout is rendered is getting rendered in a custom element. Configure the layout to customize how the element should be built."
Then show the button?
-
fago →
committed 9de9844b on 3.x authored by
junkuncz →
Issue #3426888 by junkuncz: Fix enabling config for different view-modes...
-
fago →
committed 9de9844b on 3.x authored by
junkuncz →
- Status changed to Needs review
8 months ago 5:22am 10 May 2024 -
fago →
committed 2037e562 on 3.x authored by
junkuncz →
Issue #3426888 by junkuncz, fago: Show help-text when layout-builder...
-
fago →
committed 2037e562 on 3.x authored by
junkuncz →
- Status changed to Fixed
8 months ago 6:58am 10 May 2024 Automatically closed - issue fixed for 2 weeks with no activity.