Contrib.social

Update mglaman/phpstan-drupal and make daily "updated deps" QA jobs pass

Open on Drupal.org →
Created on 25 May 2023, over 1 year ago

Problem/Motivation

@mglaman released version 1.1.34 of mglaman/phpstan-drupal (See https://github.com/mglaman/phpstan-drupal/releases/tag/1.1.34)
Looking at https://www.drupal.org/node/3060/qa → it removes some false positives on Level 1.

Steps to reproduce

See https://www.drupal.org/node/3060/qa → and notice the failures on both updated deps jobs for 10.0.x, 10.1.xand 11.x

Proposed resolution

- Upgrade mglaman/phpstan-drupal
- Create a new baseline (vendor/bin/phpstan analyze --configuration=core/phpstan.neon.dist --generate-baseline ./core/phpstan-baseline.neon)
- Bump version of mglaman/phpstan-drupal in composer.json to 1.1.34, since the newly created baseline won't pass on any version below that.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Fixed

Version

10.1 ✨

Component
PHPUnit  →

Last updated about 15 hours ago

Created by

🇳🇱Netherlands spokje

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024