Rely on commerce to hide order message

Created on 24 May 2023, almost 2 years ago
Updated 23 August 2023, over 1 year ago

Problem/Motivation

Now that Add an option to disable the add to cart message on a certain order type Fixed was committed, the code in commerce_webform_order that hides the add to cart message can be removed.

That won't be backwards compatible, but that code is now an unnecessary maintenance burden on this module.

Proposed resolution

Remove code.

Backwards compatability is probably impossible here. We could also add a status report warning if that flag was not set on an order type used in a webform but I'm not sure it's worth it.

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Closed: won't fix

Version

3.0

Component

Code

Created by

🇬🇧United Kingdom jonathanshaw Stroud, UK

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @jonathanshaw
  • Status changed to Closed: won't fix over 1 year ago
  • 🇪🇸Spain facine

    Thank you very much for reporting this, I think keeping this configuration is going to give more options to the user. So I prefer to leave it as it is.

Production build 0.71.5 2024