- Issue created by @vimal_nadar
- @vimal_nadar opened merge request.
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 6:53am 21 May 2023 - Status changed to Needs work
about 1 year ago 5:52am 22 May 2023 Tested the MR 3 on 9.5.8 and found these issues:
1. After applying the patch get this:warning: noopener_filter.module has type 100644, expected 100755
3.patch:35: new blank line at EOF.
+
warning: 1 line adds whitespace errors.2. Help is redirecting to the Website encounter error.
See the screenshots for reference.- 🇮🇳India Raveen Kumar
I have reviewed & Implemented the MR! on my Drupal website having version 9.5, PHP version - 8.1
The hook_help has been implemented successfully. Can be moved to RTBC!
Please & Thank You. - Status changed to RTBC
about 1 year ago 6:07am 22 May 2023 - 🇮🇳India Raveen Kumar
@Tanuja, The error you are facing is because of the following namespace:
use Drupal\Core\Routing\RouteMatchInterface;
Please use this namespace in your. module file. It will remove all the errors on the click of help. - 🇮🇳India Raveen Kumar
I am adding my screenshots for your reference. Please have a look. Thank you.
- 🇮🇳India Raveen Kumar
I am also adding a patch. Please have a look. Thank you.
@Raveen , after applying noopener_filter.patch , getting this error:
warning: noopener_filter.module has type 100644, expected 100755
error: patch failed: noopener_filter.module:4
error: noopener_filter.module: patch does not apply- 🇮🇳India Raveen Kumar
The error in this case also seems to be regarding the namespace in the module file.
Please add the namespace in your .module file.
It will work for you.
Thanks