- Issue created by @fjgarlin
- π§πͺBelgium BramDriesen Belgium π§πͺ
Ah, great to see an issue is created for this! π
It's also present on other banners, but because the CTA is shorter it's less visible.
- πͺπΈSpain fjgarlin
As per slack discussion:
@drumm: Probably just (fix the) z-index. Might start overlapping the call-to-action text if thereβs a lot of it; but I think any other way would end up being more work. And/or put a max width on the call to action text
I fixed the z-index and also tried to set a max-width for the call to action to avoid overlapping, but if the line spans to two lines it looks kind of worse. I think that reducing slightly the size of the image can work better if the call to action text grows.
See how three possible fixes appear on a CTA with slightly longer text.
1. Fix z-index only:
2. Fix z-index and max-width:
3. Fix z-index and reduce slightly the size of the image:
I think that 3 is the way to go and I'm creating a MR with the fixes, but I'm happy to change to 1 or 2 if needed.
- @fjgarlin opened merge request.
- Status changed to Needs review
about 1 year ago 7:37am 19 May 2023 - πͺπΈSpain fjgarlin
MR for suggestion 3: https://git.drupalcode.org/project/bluecheese/-/merge_requests/30
- Status changed to RTBC
about 1 year ago 9:37am 19 May 2023 - π§πͺBelgium BramDriesen Belgium π§πͺ
I agree, 3 seems the proper way to fix this. Code looks good as well.
- First commit to issue fork.
-
drumm β
committed d895b6f2 on 7.x-2.x authored by
fjgarlin β
Issue #3361323 by fjgarlin, BramDriesen: Banner logo hides behind the...
-
drumm β
committed d895b6f2 on 7.x-2.x authored by
fjgarlin β
- Status changed to Fixed
about 1 year ago 5:35pm 19 May 2023 - π§πͺBelgium BramDriesen Belgium π§πͺ
Thanks @drumm and @fjgarlin!
Automatically closed - issue fixed for 2 weeks with no activity.