Public function name misspelled

Created on 18 May 2023, over 1 year ago

Problem/Motivation

In DrealtyConnectionEntityController.php on line 90 there is public function viewEntityCotroller(Connection $drealty_connection, $entity_type). This should probably be named viewEntityController() but I don't know the code well enough to know if renaming it would break something.

🐛 Bug report
Status

Active

Version

4.0

Component

Code

Created by

🇨🇦Canada douglasgough

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @douglasgough
  • 🇮🇹Italy apaderno Brescia, 🇮🇹

    Since that is a controller method, and the .routing.yml file contains a _controller: '\Drupal\drealty\Controller\DrealtyConnectionEntityController::viewEntityCotroller' line, this can be either fixed or left as it is.

    entity.drealty_connection.view_page:
      path: '/admin/drealty/connection/{drealty_connection}'
      defaults:
        _controller: '\Drupal\drealty\Controller\DrealtyConnectionEntityController::viewEntityCotroller'
        entity_type: 'drealty_class'
        _title_callback: '\Drupal\drealty\Controller\DrealtyConnectionEntityController::title'
      options:
        parameters:
          drealty_connection:
            type: 'entity:drealty_connection'
      requirements:
        _permission: 'administer drealty connections'
    

    Other modules should not need to reference that method. Usually, they just need to reference the route name (entity.drealty_connection.view_page).

  • 🇨🇦Canada douglasgough

    I'll create a patch once I get my development environment up and running. Unless someone else gets to it first.

Production build 0.71.5 2024