Custom edit link jumps back to page upon saving dialog

Created on 18 May 2023, about 1 year ago
Updated 25 April 2024, about 2 months ago

First of all, thanks for creating such a nice module!

Now, for the support request:

I have a view that lists terms with a field that links to the edit page and using a custom class i got the dialog working. It opens the term edit page into a dialog, but upon saving the dialog term window, it jumps me back to the term page itself. This undoes the in-page edit function.

πŸ’¬ Support request
Status

Fixed

Version

1.0

Component

User interface

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @demon326
  • πŸ‡ΊπŸ‡ΈUnited States minnur San Francisco

    Could you please include some screenshots of the issue? Please include screenshots for each step. Or perhaps you can share a screencast

  • As requested, here are some screenshots and a video showcasing the behavior.

    Video:
    https://www.youtube.com/watch?v=GrNdb5kYeHM

    Using the 'direct' edit-link does not work in views, so that is why i used a custom css class to get it working :)

  • πŸ‡ΊπŸ‡ΈUnited States minnur San Francisco

    Thanks for the detailed report.

    Looks like there is a destination parameter in the URL and thats why its taking you to the previous page. I think this is expected behaviour.
    Please keep in mind admin_dialogs module is using dialogs API provided by the core and does not modify submission handlers

  • About that destination parameter, when NOT using a custom link, it ignores the destionation parameter and than the behaviour is as expected.

    To test it, create a taxonomy, add some terms and click on "edit", the url should have a destionation parameter.

    Now add a custom group and inside the group add a dialog with the following parameters:
    Operations -> action : "Edit" --> select the taxonomy you just created --> save

    Now go to the core taxonomy overview and list the terms and when clicking edit and than save. It should return to the overview page, not the term page itself.

    Also, the custom view edit link does not have a parameter set..

  • πŸ‡ΊπŸ‡ΈUnited States minnur San Francisco

    @demon326 thanks for the details. Will look into it over the weekend. Meanwhile can you try disabling admin_dialogs module and test taxonomy adding again see if the behaviour is similar

  • I have "solved" it by jus adding a harcoded destination parameter to the custom link. Its is not the best solution, but it works.

    With the module disabled it always goes back to "?destination=/admin/structure/taxonomy/manage//overview" , as is expected using the core interface.

    With the module disabled and no harcoded parameter using a custom views link, it goes back to the term page itself.

    I think the best solution is to provide some kind of hint or maybe a bit documentation about howto use the module in case of custom routes and or links :)

  • Status changed to Fixed 2 months ago
  • πŸ‡ΊπŸ‡ΈUnited States minnur San Francisco
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024