- Issue created by @sebish
- ๐จ๐ฆCanada sebish
Added version 10 core requirement in info as well as other minor fixes to make it Drupal 10 compatible.
- @sebish opened merge request.
- Status changed to Needs work
almost 2 years ago 6:54am 18 May 2023 - ๐ฎ๐ณIndia dineshkumarbollu
Hi
I review the MR!1 found 1 d10 compatible issues.
vendor/bin/drush upgrade_status:analyze eudonet
[notice] Processing /var/www/html/vbd9/web/modules/contrib/eudonet-3361104.================================================================================
Eudonet, --
Scanned on Thu, 05/18/2023 - 12:21FILE: web/modules/contrib/eudonet-3361104/tests/src/Functional/LoadTest.php
STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 13 Drupal\Tests\BrowserTestBase::$defaultTheme is required. See
https://www.drupal.org/node/3083055 โ , which includes
recommendations on which theme to use.
-------------------------------------------------------------------------------- - ๐จ๐ฆCanada sebish
It looks like a phpstan-drupal error. As mentionned here. https://github.com/mglaman/phpstan-drupal/issues/559.
We could set$defaultTheme
as'stark'
but it would also be deprecated.
Weirdly enough, I can't see that error from upgrade_status. When I run it I get:================================================================================
Eudonet, --
Scanned on jeu 18/05/2023 - 11:02No known issues found.
- ๐จ๐ฆCanada jigarius Montrรฉal
Dear maintainers.
Do you plan to release a Drupal 10 compatible version soon? Also, since the module page says "minimally maintained" and "maintenance fixes only", do you recommend that we use this module in our project or would you recommend starting our own fork or maybe write our own library to connect with Eudonet?
- ๐ซ๐ทFrance sbruyas
We don't really maintain this module anymore. That's why I'm offering you the possibility of maintaining it if you wish?
This module is the correct way to abstract eudonet integration so it's a good start!
- ๐จ๐ฆCanada jigarius Montrรฉal
Please feel free to make me an owner/maintainer in that case.
- Status changed to Fixed
over 1 year ago 2:22pm 3 October 2023 - ๐จ๐ฆCanada jigarius Montrรฉal
Thanks Seb, for the pull request. It's merged and 2 new releases have been created: a dev and a stable.
Automatically closed - issue fixed for 2 weeks with no activity.