- Issue created by @kopeboy
- Status changed to Needs work
over 1 year ago 12:04am 15 November 2023 - 🇺🇸United States dww
Yup, I needed exactly the same. Thanks for opening the issue about it.
Here's the start of a solution. This fixes the 'Add profile' local action. Still "needs work" to also fix the page title of the add form itself.
- last update
over 1 year ago 18 pass, 2 fail - 🇺🇸United States dww
This fixes the title of the add form, too. I reproduced the test fails locally, so that's coming next. 😅 Fixing version so we can open an MR, instead of patches.
- last update
over 1 year ago 23 pass - Status changed to Needs review
over 1 year ago 12:41am 15 November 2023 - 🇺🇸United States dww
Still need this. 😅 There were merge conflicts, so I rebased the MR. There's a phpcs and phpstan (max PHP version) failure in
profile.module
that's untouched by this MR. Not sure what's going on with that, but seems out of scope to fix it here.phpcs
-------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 71 | ERROR | [x] Parameter $items has null default value, but is not marked as | | nullable. | | (SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue.NullabilityTypeMissing)
phpstan (max PHP version)
------ ----------------------------------------------------------------------- Line profile.module ------ ----------------------------------------------------------------------- 71 Deprecated in PHP 8.4: Parameter #4 $items (Drupal\Core\Field\FieldItemListInterface) is implicitly nullable via default value null. ------ ----------------------------------------------------------------------- [ERROR] Found 1 error
Trivial fix, but seems out of scope. Not sure why this pipeline is complaining about it, since I didn't touch that and it's identical in the 8.x-1.x branch (which seems to be passing).
- First commit to issue fork.
-
jsacksick →
committed 83b291b9 on 8.x-1.x authored by
dww →
Issue #3360825 by dww: Use profile type label instead of "profile" in...
-
jsacksick →
committed 83b291b9 on 8.x-1.x authored by
dww →
Automatically closed - issue fixed for 2 weeks with no activity.