Drupal\acquia_dam\AcquiadamAuthService::refreshAccessToken():

What is the exact error? This is just a class and method name.

I'm getting
TypeError: Drupal\acquia_dam\AcquiadamAuthService::refreshAccessToken(): Argument #1 ($refresh_token) must be of type string, null given, called in /app/docroot/modules/contrib/acquia_dam/src/Client/AcquiaDamClientFactory.php on line 175 in Drupal\acquia_dam\AcquiadamAuthService->refreshAccessToken() (line 309 of /app/docroot/modules/contrib/acquia_dam/src/AcquiadamAuthService.php)

I'm hitting that error because I'm having issues connecting today. I made a MR that checks to be sure that the user has a token. After I add that, I'm still not able to connect, but I get directed to my media library and there's a message:
Something went wrong contacting Acquia DAM, the search could not be completed.

Thanks for helping explain the error, this seems reasonable if it's a type error.

Updated the MR. Is that the right fix for this?
I also added the check to getRefreshToken and removed "?" from "?string" because it shouldn't return null.

That looks right! Thank you for making the fix. This is in our sprint right now, so I'll review it and get it committed.

Yep, this looks great. It fixes passing null to \Drupal\acquia_dam\AcquiadamAuthService::refreshAccessToken and removes null|string from those two methods.

But now I'm concerned that the OAuth refresh middleware is running when it isn't supposed to, and that's why we saw this bug.

The error lies here:

            if (!$value instanceof ResponseInterface) {
              return $value;
            }
            if ($value->getStatusCode() !== 401) {
              return $value;
            }

We can get a 401 unauthorized request before the site is configured. The code doesn't check auth_type. It assumes a refresh token should be used on 401.

Merged! We'll have a release soon with the fix. Thanks @capysara.

Automatically closed - issue fixed for 2 weeks with no activity.

japerry → closed merge request !14