\Drupal::entityTypeManager()->getStorage call should be avoided use dependency injection instead

FILE: \modules\contrib\link_filebrowser\src\Controller\LinkFileBrowserController.php -------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------- 75 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead --------------------------------------------------------------------------------------------------------------------

Comments & Activities

Issue created by @Shanu Chouhan
Issue was unassigned.
Status changed to Needs review over 1 year ago8:45am 15 May 2023
Comment over 1 year ago →
🇮🇳India Shanu Chouhan
Here's a patch for it.
Status changed to RTBC over 1 year ago1:24pm 19 May 2023
Comment over 1 year ago →
🇵🇭Philippines kenyoOwen
Hi Shanu Chouhan

After running phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml link_filebrowser, I applied patch #2 to the “Link file browser” module and confirmed that the issue mentioned is resolved. Please see the screenshots attached.

For your review.
Thank you.
Status changed to Closed: outdated over 1 year ago11:11pm 18 June 2023
Comment over 1 year ago →
🇫🇷France lazzyvn paris
Oh this patch is not good
for controller you don't have to use dependency injection it just use $this->entityTypeManager()

\Drupal::entityTypeManager()->getStorage call should be avoided use dependency injection instead

Problem/Motivation

Steps to reproduce

Proposed resolution

Comments & Activities