Typehint on IntervalItemInterface::getPeriod() is incorrect.

Created on 12 May 2023, over 1 year ago
Updated 14 May 2023, over 1 year ago

Problem/Motivation

Phpstan caught that this says it returns an int, but it actually returns a string.

Steps to reproduce

E.g.:

  82     Strict comparison using === between int and 'day' will always evaluate to false.                                
  86     Strict comparison using === between int and 'quarter' will always evaluate to false.                            

Proposed resolution

Change typehint.

Remaining tasks

Review.

User interface changes

None.

API changes

None.

Data model changes

None.

πŸ› Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States bradjones1 Digital Nomad Life

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024