Use dependency injection for config factory

Open on Drupal.org →

Created on 12 May 2023, over 1 year ago

Problem/Motivation

Currently the ConfigFactory used in class HeaderEventSubscriber() does not use dependency injection. It should do this.

Steps to reproduce

Run the command:

phpcs --standard=DrupalPractice
/web/modules/contrib/smart_content_cdn/

Proposed resolution

Fix the following coding standards issues and upload the patch or create an MR with fixes.

FILE: \modules\contrib\smart_content_cdn\src\EventSubscriber\HeaderEventSubscriber.php
--------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------
30 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------------------------------

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task

Status

Version

1.0

Component

Code

Created by

🇮🇳India Shanu Chouhan

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @Shanu Chouhan
Status changed to Needs review over 1 year ago10:55am 12 May 2023
Comment over 1 year ago →
🇮🇳India Shanu Chouhan
Here's a patch for it.
Assigned to Kaustab_Roy
Comment over 1 year ago →
🇮🇳India Kaustab_Roy
i will review it
Status changed to Needs work over 1 year ago8:07pm 12 May 2023
Comment over 1 year ago →
🇮🇳India Kaustab_Roy
After applying patch #2.
proposed command doesnot throw any exceptions But
phpcs --standard=DrupalPractice for the module
Have errors (screenshot attached)
Issue was unassigned.
Status changed to RTBC over 1 year ago8:10pm 12 May 2023
Comment over 1 year ago →
🇮🇳India Kaustab_Roy
Found out:
The comment #4 issue have been resolved in this issue:
https://www.drupal.org/project/smart_content_cdn/issues/3359946 📌 \Drupal::entityTypeManager()->getStorage call should be avoided use dependency injection instead Needs review

So changing the status to RTBC.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024