Contrib.social

D10 compatibility

Open on Drupal.org →
Created on 11 May 2023, over 1 year ago
Updated 29 June 2024, 6 months ago

Problem/Motivation

Upgrade this module to work with Drupal 10

Steps to reproduce

None.

Proposed resolution

Build a patch that can be applied after the Drupal 9 rector patch in issue https://www.drupal.org/project/moderation_scheduler/issues/3141162 📌 Automated Drupal Rector fixes Needs review

Remaining tasks

Apply both patches to 8.x-dev branch and create a new release.

User interface changes

None

API changes

None

Data model changes

None

🐛 Bug report
Status

Closed: outdated

Version

9.0

Component

Documentation

Created by

🇬🇧United Kingdom Rory Downes

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Rory Downes
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 5.3 & MySQL 5.5
    last update 11 months ago
    Patch Failed to Apply
  • Comment 10 months ago →
    🇧🇾Belarus e.bogatyrev

    e.bogatyrev → made their first commit to this issue’s fork.

  • Merge request !1Issue#3359604: Fixed D10 compatibility issues. → (Closed) created by e.bogatyrev
  • Status changed to Needs review 10 months ago
  • Comment 10 months ago →
    🇧🇾Belarus e.bogatyrev

    Hi everyone,

    I cannot apply the initial patch due the errors. I have to create a new one.
    Before creation see the following issues.

    [notice] Processing /var/www/html/web/modules/contrib/moderation_scheduler.

================================================================================
Moderation Scheduler,  8.x-1.x-dev
Scanned on Sat, 02/17/2024 - 13:26

FILE: web/modules/contrib/moderation_scheduler/moderation_scheduler.module

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Fix now        59   Call to deprecated constant REQUEST_TIME: Deprecated in
                    drupal:8.3.0 and is removed from drupal:11.0.0. Use
                    Drupal::time()->getRequestTime();
--------------------------------------------------------------------------------
Fix now        70   Call to deprecated constant REQUEST_TIME: Deprecated in
                    drupal:8.3.0 and is removed from drupal:11.0.0. Use
                    Drupal::time()->getRequestTime();
--------------------------------------------------------------------------------
Fix now        73   Call to deprecated constant REQUEST_TIME: Deprecated in
                    drupal:8.3.0 and is removed from drupal:11.0.0. Use
                    Drupal::time()->getRequestTime();
--------------------------------------------------------------------------------

FILE:
web/modules/contrib/moderation_scheduler/src/Form/ModerationScheduleForm.php

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Fix now        98   Call to deprecated constant REQUEST_TIME: Deprecated in
                    drupal:8.3.0 and is removed from drupal:11.0.0. Use
                    Drupal::time()->getRequestTime();
--------------------------------------------------------------------------------
Fix now        102  Call to deprecated constant REQUEST_TIME: Deprecated in
                    drupal:8.3.0 and is removed from drupal:11.0.0. Use
                    Drupal::time()->getRequestTime();
--------------------------------------------------------------------------------
Fix now        225  Call to deprecated constant REQUEST_TIME: Deprecated in
                    drupal:8.3.0 and is removed from drupal:11.0.0. Use
                    Drupal::time()->getRequestTime();
--------------------------------------------------------------------------------

    After applying own patch

     [notice] Processing /var/www/html/web/modules/contrib/moderation_scheduler.

================================================================================
Moderation Scheduler,  8.x-1.x-dev
Scanned on Sat, 02/17/2024 - 13:35
No known issues found.

    Please review

  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 5.3 & MySQL 5.5
    last update 10 months ago
    Patch Failed to Apply
  • Merge request !2Issue#3359604: Fixed D10 compatibility issues. → (Merged) created by e.bogatyrev
  • Comment 10 months ago →
    System Message
  • Comment 10 months ago →
    🇧🇾Belarus e.bogatyrev

    Re-attached the patch to fix test issues

  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 5.3 & MySQL 5.5
    last update 10 months ago
    Composer error. Unable to continue.
  • Merge request !3Issue#3359604: Fixed D10 compatibility issues. → (Merged) created by e.bogatyrev
  • Comment 10 months ago →
    System Message
  • Pipeline finished with Skipped
    10 months ago
    #97911
  • First commit to issue fork.
  • Comment 10 months ago →
    System Message
  • Comment 10 months ago →
    🇮🇹Italy bigbabert Milano, Italy
  • Status changed to RTBC 10 months ago
  • Comment 10 months ago →
    🇮🇹Italy bigbabert Milano, Italy
  • Status changed to Closed: outdated 6 months ago
  • Comment 6 months ago →
    🇮🇹Italy bigbabert Milano, Italy
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024