- Issue created by @wim leers
- Status changed to Needs review
over 1 year ago 3:41pm 10 May 2023 - last update
over 1 year ago 2 pass, 2 fail The last submitted patch, 2: 3359418-2.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- 🇭🇺Hungary Gábor Hojtsy Hungary
Great, thanks for working on this! Fails with this though. The invocation of the method is added in the patch but the method is not :)
Call to undefined method Drupal\config_inspector\ConfigInspectorManager::violationsToArray()
Drupal\config_inspector\Controller\ConfigInspectorController->formatList()() (Line: 334) - Status changed to Needs work
over 1 year ago 12:29pm 12 May 2023 - last update
over 1 year ago 3 pass - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 5:28pm 15 May 2023 - last update
over 1 year ago 3 pass - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Ready for review!
Updated
drushcapabilities demonstrated:-
$ vendor/bin/drush config:inspect ----------------------------------------------------------- ---------- ---------- Key Status Data ----------------------------------------------------------- ---------- ---------- automated_cron.settings Correct Valid automatic_updates.settings Correct Valid block.block.claro_breadcrumbs Correct Valid block.block.claro_content Correct Valid block.block.claro_help Correct Valid block.block.claro_local_actions Correct Valid … tour.tour.block-layout Correct Valid tour.tour.cdn-ui 8 errors tour.tour.views-ui Correct Valid update.settings Correct 1 errors user.flood Correct Valid … views.view.watchdog Correct Valid views.view.who_s_new Correct Valid views.view.who_s_online Correct Valid ----------------------------------------------------------- ---------- ---------- -
$ vendor/bin/drush config:inspect --only-error --------------------- ---------- ---------- Key Status Data --------------------- ---------- ---------- editor.editor.cke4 1 errors media.settings Correct 1 errors system.theme.global Correct 1 errors tour.tour.cdn-ui 8 errors update.settings Correct 1 errors --------------------- ---------- ---------- -
$ vendor/bin/drush config:inspect --only-error --detail ------------------------------------------------------------------- ---------------- ---------- Key Status Data ------------------------------------------------------------------- ---------------- ---------- editor.editor.cke4:settings.plugins.codesnippet missing schema media.settings Correct 1 errors system.theme.global Correct 1 errors tour.tour.cdn-ui:tips.cdn-ui-status.attributes missing schema tour.tour.cdn-ui:tips.cdn-ui-mapping.attributes missing schema tour.tour.cdn-ui:tips.cdn-ui-mapping-type.attributes missing schema tour.tour.cdn-ui:tips.cdn-ui-mapping-simple-domain.attributes missing schema tour.tour.cdn-ui:tips.cdn-ui-mapping-simple-scheme.attributes missing schema tour.tour.cdn-ui:tips.cdn-ui-mapping-simple-conditions.attributes missing schema tour.tour.cdn-ui:tips.cdn-ui-farfuture.attributes missing schema tour.tour.cdn-ui:tips.cdn-ui-streamwrappers.attributes missing schema update.settings Correct 1 errors ------------------------------------------------------------------- ---------------- ----------
-
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
As you can see, the Drush output matches that in the UI exactly. 🤓
- last update
over 1 year ago 3 pass - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
#9.3 was actually not yet correct:
$ vendor/bin/drush config:inspect --only-error --detail … media.settings Correct 1 errors system.theme.global Correct 1 errors … update.settings Correct 1 errorsshould have been:
-
$ vendor/bin/drush config:inspect --only-error --detail --------------------------------------------------------------- ---------------- ----------------------------------------------------- Key Status Data --------------------------------------------------------------- ---------------- ----------------------------------------------------- editor.editor.cke4:settings.plugins.codesnippet missing schema media.settings:iframe_domain Correct This value should be of the correct primitive type. system.theme.global:logo.url Correct This value should be of the correct primitive type. tour.tour.cdn-ui:tips.cdn-ui-status.attributes missing schema tour.tour.cdn-ui:tips.cdn-ui-mapping.attributes missing schema tour.tour.cdn-ui:tips.cdn-ui-mapping-type.attributes missing schema tour.tour.cdn-ui:tips.cdn-ui-mapping-simple-domain.attributes missing schema tour.tour.cdn-ui:tips.cdn-ui-mapping-simple-scheme.attributes missing schema tour.tour.cdn-ui:tips.cdn-ui-mapping-simple-conditions.attrib missing schema utes tour.tour.cdn-ui:tips.cdn-ui-farfuture.attributes missing schema tour.tour.cdn-ui:tips.cdn-ui-streamwrappers.attributes missing schema update.settings:fetch.url Correct This value should be of the correct primitive type. --------------------------------------------------------------- ---------------- -----------------------------------------------------
Fix attached :)
-
- Status changed to RTBC
over 1 year ago 11:17am 18 May 2023 - 🇭🇺Hungary Gábor Hojtsy Hungary
Yeah I was wondering about #9.3 where it was listing correct stuff too with the only error flag. Looks great IMHO.
- eb710260 committed on 2.1.x
Issue #3359418 by Wim Leers: Expose validation constraint violations in...
- eb710260 committed on 2.1.x
- Status changed to Fixed
over 1 year ago 8:00am 19 May 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Yay! This unblocks ✨ Expose validation constraints (and validatability %) in Config Inspector UI Fixed — expect a big update there later today!
Automatically closed - issue fixed for 2 weeks with no activity.
