- Issue created by @mrshowerman
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 12:33pm 10 May 2023 - last update
over 1 year ago 83 pass - π©πͺGermany mrshowerman Munich
Initial patch that brings back fragment and query to the link field value.
- πΊπΈUnited States mark_fullmer Tucson
Thanks much! I'm adding this to my "review in the next week" list :)
- last update
over 1 year ago 83 pass - πΊπΈUnited States mark_fullmer Tucson
The patch in #2 didn't seem to handle query parameters correctly. Per Drupal's
Url
docblock comments, it needs to be an array:* - 'query': An array of query key/value-pairs (without any URL-encoding) * to append to the URL.
I modeled the patch revision on Drupal core's method for preparing query parameters.
There was test coverage for the initial rendering of the link with an anchor, but no test coverage for revisiting the edit form, which is what this issue is related to. I've added test coverage for that.
- π©πͺGermany mrshowerman Munich
Awesome! Works like a charm. I have to admit that my main focus was the fragment part. With the new patch, query strings work as well now π.
-
mark_fullmer β
committed 002b8aee on 6.1.x
Issue #3359375 by mrshowerman, mark_fullmer: Query fragments or anchors...
-
mark_fullmer β
committed 002b8aee on 6.1.x
-
mark_fullmer β
committed 300606a4 on 6.0.x
Issue #3359375 by mrshowerman, mark_fullmer: Query fragments or anchors...
-
mark_fullmer β
committed 300606a4 on 6.0.x
- Status changed to Fixed
over 1 year ago 4:18pm 16 May 2023 - πΊπΈUnited States mark_fullmer Tucson
Thanks for the review!
Committed to 6.1.x (Drupal 10.1.x) and cherry-picked for 6.0.x (Drupal 10.0.x).
Automatically closed - issue fixed for 2 weeks with no activity.