- Issue created by @nickdickinsonwilde
- @nickdickinsonwilde opened merge request.
- Status changed to Needs review
almost 2 years ago 1:44pm 8 May 2023 - 🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)
MR in case you decide that is an appropriate fix
- 🇪🇸Spain fjgarlin
Thanks for creating the issue.
We should change it where the function is being called.
I believe is line 3477
$var = self::linkName($item->getVar() ?? $item->getMemberName(), $branch, '', '', $item->id(), $item->getClass(), NULL, FALSE, TRUE, NULL, NULL, 'class');
And it should be changed to
$var = self::linkName($item->getVar() ?? $item->getMemberName(), $branch, '', '', $item->id(), $item->getClass()->id(), NULL, FALSE, TRUE, NULL, NULL, 'class');
Do you want to try that and let me know. Feel free to create the MR with the change as well.
- Status changed to Needs work
almost 2 years ago 1:46pm 8 May 2023 - @nickdickinsonwilde opened merge request.
- Status changed to Needs review
almost 2 years ago 2:08pm 8 May 2023 - 🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)
Tested that and it didn't work. The linkName is being called in this instance through a callback through the documentation link - rather than that line. Here's another MR with a new suggestion.
-
fjgarlin →
committed 63dbadaf on 2.x authored by
NickDickinsonWilde →
Issue #3358881 by NickDickinsonWilde: class_id is passed as object...
-
fjgarlin →
committed 63dbadaf on 2.x authored by
NickDickinsonWilde →
- Status changed to Fixed
almost 2 years ago 2:47pm 8 May 2023 - 🇪🇸Spain fjgarlin
I like it better as it's sending the parameter in the expected format (an ID and not an object).
Merged! Thanks again, it's great that you're testing it in these many modules. - 🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)
Thanks for the quick discussion and commiting! Very much appreciated, still adding more modules to my list/configuring/theming stuff so not unlikely I'll have more in the next few weeks.
- @nickdickinsonwilde opened merge request.
- Status changed to Needs review
almost 2 years ago 6:09pm 9 May 2023 - 🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)
Slight adjustment/new PR - Some cases don't have a class - ex api/advagg/advagg_js_minify!jsminplus.inc/constant/JS_NEW_WITH_ARGS/8.x-2.x
-
fjgarlin →
committed b4355083 on 2.x authored by
NickDickinsonWilde →
Issue #3358881 by NickDickinsonWilde, fjgarlin: class_id is passed as...
-
fjgarlin →
committed b4355083 on 2.x authored by
NickDickinsonWilde →
- Status changed to Fixed
almost 2 years ago 9:43am 10 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.