Add Glyphicons to labels automatically in SPA

Issue created by @Ryo Yamashita
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
366 pass
@ryo-yamashita opened merge request.
Status changed to Needs review about 1 year ago8:33am 8 May 2023
Comment about 1 year ago →
🇯🇵Japan Ryo Yamashita
@yas

Please review it. Thanks.
Status changed to Needs work about 1 year ago8:57am 8 May 2023
Comment about 1 year ago →
🇺🇸United States yas California 🇺🇸
@ryo-yamashita

I posted my quick question and marked as Needs work. Thanks!
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
366 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
366 pass
Status changed to Needs review about 1 year ago2:15am 9 May 2023
Comment about 1 year ago →
🇯🇵Japan Ryo Yamashita
@yas

I fixed the description so that other icon information set in Bootstrap.php can also be displayed. Thanks.
Status changed to Needs work about 1 year ago4:45am 9 May 2023
Comment about 1 year ago →
🇺🇸United States yas California 🇺🇸
@ryo-yamashita

Thank you for the update. I posted my comments. Thanks
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
366 pass
Status changed to Needs review about 1 year ago5:50am 9 May 2023
Comment about 1 year ago →
🇯🇵Japan Ryo Yamashita
@yas

As pointed out in the comment, unnecessary icon information records have been removed.
Also, the logic for identifying icons has been changed to use the find method as advised. Thanks.
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
366 pass
Status changed to Needs work about 1 year ago8:59am 9 May 2023
Comment about 1 year ago →
🇺🇸United States yas California 🇺🇸
@ryo-yamashita

Thank you for the update. I posted my comment. Thanks
Comment about 1 year ago →
🇺🇸United States yas California 🇺🇸
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
366 pass
Status changed to Needs review about 1 year ago4:11am 10 May 2023
Comment about 1 year ago →
🇯🇵Japan Ryo Yamashita
Comment about 1 year ago →
🇺🇸United States yas California 🇺🇸
@ryo-yamashita

I understood the patch. It looks good to me. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.
Status changed to RTBC about 1 year ago5:03am 10 May 2023
Comment about 1 year ago →
🇺🇸United States yas California 🇺🇸
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
366 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
366 pass
Comment about 1 year ago →
System Message

yas → committed ea089ba8 on 6.x authored by Ryo Yamashita →
Issue #3358789 by Ryo Yamashita, yas: Add Glyphicons to labels...
Comment about 1 year ago →
System Message

yas → committed f9fda0ba on 5.x authored by Ryo Yamashita →
Issue #3358789 by Ryo Yamashita, yas: Add Glyphicons to labels...
Status changed to Fixed about 1 year ago8:26am 10 May 2023
Comment about 1 year ago →
🇺🇸United States yas California 🇺🇸
Comment about 1 year ago →
🇺🇸United States yas California 🇺🇸
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Add Glyphicons to labels automatically in SPA

Problem/Motivation

Comments & Activities