- Issue created by @keinstein
- ๐บ๐ธUnited States karlshea Minneapolis ๐บ๐ธ
This used to work, but ics-parser moved any custom properties to a private
$additionalProperties
array, making it impossible to get that data into the Feeds data transfer object.See https://github.com/u01jmg3/ics-parser/issues/318 and https://github.com/u01jmg3/ics-parser/issues/329
- Status changed to Needs review
12 months ago 8:50pm 30 November 2023 - ๐บ๐ธUnited States karlshea Minneapolis ๐บ๐ธ
Patch attached that uses reflection, it's not a great solution but it's working for me.
- ๐บ๐ธUnited States karlshea Minneapolis ๐บ๐ธ
Property visibility fixed in https://github.com/u01jmg3/ics-parser/issues/329.
The patch could be changed to not use reflection, but it would require the patched version of ics-parser (whenever it's released) to be installed.
- Assigned to ben.hamelin
- ๐บ๐ธUnited States ben.hamelin Adirondack Mountains, NY
@KarlShea - looks like we got that release in 3.4.0
https://github.com/u01jmg3/ics-parser/releases/tag/v3.4.0We could plan to up the requirement here and release this as 2.2.0
- ๐บ๐ธUnited States karlshea Minneapolis ๐บ๐ธ
Bumped ics-parser to ^3.4 and removed reflection
-
ben.hamelin โ
committed 7ee3af69 on 2.x-dev authored by
KarlShea โ
Resolve #3358713 "Add additional fields" Increase johngrogg/ics-parser...
-
ben.hamelin โ
committed 7ee3af69 on 2.x-dev authored by
KarlShea โ
- Status changed to Fixed
8 months ago 7:07pm 29 March 2024 - ๐บ๐ธUnited States ben.hamelin Adirondack Mountains, NY
Committed and released with 2.2.0.
Thanks @KarlShea!! Automatically closed - issue fixed for 2 weeks with no activity.